[PATCH] Gamesetup chat colors wrong

[Stan]

We experienced the bug today on r17108

Steps to reproduce :

1. Open the lobby
2. Join a game
3. Ask the host to change player colors

You will see that you kept the original color for the chat, while you should have a new one.

[AlThePhoenix]

This also happens when hosting a game yourself and it is not an updating issue. The problem is that gamesetup.js' mapSettings refers to the color set in the map's .xml file (or in case of Random Map, the default colors); see gamesetup.js in function addChatMessage(msg) at lines 1800-1808.

1. Make sure preserve match settings is activated
2. Host a game (no need to go into the lobby)
3. Be the first player (default) and change your color
4. Write a message and notice how your chat color is still blue
5. Leave the game and host again
6. See 4.

[AlThePhoenix]

I used playerData[playerSlot].Color from function selectPlayerColor(playerSlot, colorIndex). Works for me so far, but I'm not sure if this is the proper way to do it.

[elexis]

Right, if we read the player color from the map settings, then it's no surprise it doesn't update when changing the color with #1580.

[elexis]

Credit goes to Evulant (AlThePhoenix).

[AlThePhoenix]

Better approach

[AlThePhoenix]

Nevermind me. Didn't refresh the page x)

[mimo]

In 17112:

fix wrong chat colors, patch by AlThePhoenix, fixes #3489

[mimo]

Thanks for the patch