Opened 9 years ago

Last modified 6 years ago

#3534 new defect

Pathfinder - Some unused constants

Reported by: elexis Owned by:
Priority: Nice to Have Milestone: Backlog
Component: Core engine Keywords: pathfinding
Cc: Patch:

Description (last modified by Itms)

WAYPOINT_ADVANCE_MAX and SHORT_PATH_GOAL_RADIUS were both introduced in r10902 and all places where they were used were removed in r16751. But they are still defined in CCmpUnitMotion.cpp.

There might be more unused constants, see also #3500. At least all the other constants in CCmpUnitMotion.cpp are in use.

Was that functionality actually removed? If so, that might also explain #3530. 

/**
 * When short-pathing to an intermediate waypoint, we aim for a circle of this radius
 * around the waypoint rather than expecting to reach precisely the waypoint itself
 * (since it might be inside an obstacle).
 */
static const entity_pos_t SHORT_PATH_GOAL_RADIUS = entity_pos_t::FromInt(TERRAIN_TILE_SIZE*3/2);

Change History (2)

comment:1 by Itms, 8 years ago

Owner: set to Itms

comment:2 by Itms, 6 years ago

Description: modified (diff)
Owner: Itms removed

SHORT_PATH_GOAL_RADIUS is now in use, the other one is not. As much as I dislike unused stuff, this constant has a historical function and a sound value (tested over the years) so it would be nice to let people who work on this in the future know it existed...

In a nutshell, not sure what to do with it.

Note: See TracTickets for help on using tickets.