#3535 closed defect (fixed)
[PATCH] Chat messages get drawn over the diplomacy window
| Reported by: | AlThePhoenix | Owned by: | elexis |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 20 |
| Component: | UI & Simulation | Keywords: | |
| Cc: | Patch: |
Description (last modified by )
When more than 12 chat messages are visible at the same time, they start overlapping with the diplomacy window if it is opened and the messages are long enough.
Apart from that the chat window isn't correctly drawn over the diplomacy window.
Attachments (5)
Change History (16)
by , 9 years ago
| Attachment: | 0AD_Spam.jpg added |
|---|
by , 9 years ago
| Attachment: | 0AD_DiplomacyWindow_ChatWindow.jpg added |
|---|
comment:1 by , 9 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 9 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 8 years ago
| Keywords: | simple added |
|---|---|
| Milestone: | Backlog → Alpha 20 |
by , 8 years ago
| Attachment: | chat_messages_get_drawn_over_the_diplomacy_window.patch added |
|---|
comment:4 by , 8 years ago
| Keywords: | review patch added |
|---|---|
| Summary: | Chat messages get drawn over the diplomacy window → [PATCH] Chat messages get drawn over the diplomacy window |
comment:5 by , 8 years ago
| Keywords: | review removed |
|---|
by , 8 years ago
| Attachment: | chat_messages_get_drawn_over_the_diplomacy_window_v2.patch added |
|---|
comment:6 by , 8 years ago
| Keywords: | review added; simple removed |
|---|
by , 8 years ago
| Attachment: | chat_messages_get_drawn_over_the_diplomacy_window_v3.patch added |
|---|
comment:8 by , 8 years ago
| Keywords: | patch removed |
|---|
Thanks for the patch. Your version addresses the two issues described in the ticket. The same issue remains for the trade dialog though.
If the chat input is drawn below the diplomacy manager, the user can interact with an invisible window. Drawing it above the diplomacy manager might work, but then interaction with the diplomacy dialog is limited. Looking at the code, it would be more coherent to just close previous dialogs, eliminating those z-ordering as well.
comment:10 by , 8 years ago
| Keywords: | review removed |
|---|
comment:11 by , 5 years ago
| Description: | modified (diff) |
|---|
Note:
See TracTickets
for help on using tickets.
The patch enforces that the chat-messages are always drawn below the chat-input-window. It works with -1 but not 0.
But the patch doesn't address the issue of chat-input-window and diplomacy manager being opened simultaneously (see screenshot).