Opened 9 years ago

Closed 8 years ago

#3567 closed enhancement (fixed)

[PATCH] Allow maxFailCount to be set by random-map scripts placing objects

Reported by: Stan Owned by: Stan
Priority: If Time Permits Milestone: Alpha 20
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

Since we support default params in Js, it was easy to fix the TODO, without breaking the wall RMGEN code.

Attachments (1)

AllowMaxFailCounttobesetbytheuser.diff​ (1.3 KB ) - added by Stan 9 years ago.
A proposal.

Download all attachments as: .zip

Change History (6)

by Stan, 9 years ago

Attachment: AllowMaxFailCounttobesetbytheuser.diff​ added

A proposal.

comment:1 by Stan, 9 years ago

Keywords: patch review added
Status: new → assigned

comment:2 by Josh, 9 years ago

Keywords: reviewed added; review removed

Looks good.

comment:3 by FeXoR, 8 years ago

Will be added in #2944

comment:4 by elexis, 8 years ago

Component: Core engine → UI & Simulation
Keywords: reviewed removed
Priority: Should Have → If Time Permits
Summary: [PATCH] Allow Max Fail Count to be set by the user → [PATCH] Allow maxFailCount to be set by random-map scripts placing objects
Type: defect → enhancement

Adding this since the patch is correct and #2944 is outdated since some months. The patch doesn't add much, so better ask on IRC if you have small optimizations than making a ticket.

comment:5 by elexis, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 17649:

Allow randommap-scripts to set a custom fail-limit when placing objects. Patch by Stan, fixes #3567.

Note: See TracTickets for help on using tickets.