Lobby - no gamelist after logging in

[elexis]

Some people noticed this issue today. The gamelist was not loaded when entering the lobby. It seems not to be a XPartaMupp issue as the other players could use it simultaneously.

[Josh]

That code hasn't changed in years, and I've never heard of this issue before. I need more information.

Based on the information here, I would guess that they just have a very slow or overloaded internet connection causing the gamelist to take awhile to load.

[elexis]

I could reproduce it myself.

As we updated the lobby code in r16961, r16997 and others, there is likely some initial update not occuring. Will debug. See also #3388.

[elexis]

Reproduce: Host a lobbied game with one instance and join the lobby with another client. Repeat joining the lobby until the bug occurs. Happens in like one of 5 times in an otherwise empty lobby.

After adding debug output to lobby.js and XmppClient.cpp, it seems that XmppClient::handleIq doesn't receive games, while wireshark indicates that there is a valid gamelist, need to test more.

If the host changes a setting after that, the game will appear.

[elexis]

In case of the bug, XmppClient::handleIq never receives the GameListQuery. I checked with wireshark and actually its teh XPartaMupp server which doesn't send the gamelist.

I'm not convinced this a big issue on a19 as there should be regular gamelist updates because of many games being played.

Maybe this bug even exists on a18 and we just didn't notice.

[elexis]

scythewirler removed the check on lastLeft in muc_online in XPartaMupp.py. This fixes the issue for me. No matter how often I rejoin the lobby, the game is always listed.

The ticket can be closed, but the change should be commited, before it is lost.

Can be pushed to A20 too, as it is not a problem with 0 A.D. itself apparently.

[scythetwirler]

In 17206:

Removes extraneous check from XpartaMuPP. Fixes #3568.