[PATCH] Scenario player colors are replaced

[AlThePhoenix]

Some custom player colours on maps are being replaced with the closest colour you could select in a random map or skirmish match. This doesn't make much sense for scenarios though (most likely an oversight).

Reproduce: Go into Atlas, change any player's colour to R 141 G 61 B 61 and save it as a scenario. When selecting that map in the gamesetup that player's colour will be black instead. This works with some other custom colours as well; I had another colour be replaced with green (I'm not sure how the replacement algorithm works).

[Stan]

This is as far as I can remember intended behaviour to prevent wrong colors. Now I agree with you that it should be fixed for scenarios.

[elexis]

Refs #3431

[elexis]

In 17320:

Don't replace the custom colors of scenario maps with default colors. Fixes #3627.

[elexis]

Notice one can still change the colors in atlas for skirmish maps (which will be replaced with the closest matching default colors). This might/should be changed at some point. Same goes for starting resources and possibly other settings which can be changed in the gamesetup for skirmish maps.