[PATCH] Some javascript errors after playing for more than 2 hours

[fz72]

After playing for 2 hours I got some AI errors. I played on a huge map for 6 players but only with 2 KIs. Revision: 17297.

[fz72]

interestinglog.html

[historic_bruno]

Please attach the commands.txt for that game (from the game's log folder), it will be needed to reproduce the problem.

[fz72]

I think this are the right commands.txt

[fz72]

The first error appears on 2:16. One unit failed to pack when I wanted to garrison the bolt gun.

[Lionkanzen]

I Got these

WARNING: JavaScript warning: simulation/components/UnitAI.js line 1941 reference to undefined property this.orderQueue[0].data.attackType

WARNING: unexpected PathResult (2475 3 3)

WARNING: unexpected PathResult (2560 3 3)

WARNING: unexpected PathResult (2266 3 3)

WARNING: JavaScript warning: simulation/components/UnitAI.js line 1710 reference to undefined property this.order.data.attackType

Engine exited successfully on 2015-11-20 at 20:15:35 with 4653 message(s), 0 error(s) and 5 warning(s).

[mimo]

Lionkanzen, from the errors you get, this must be a different issue. So please open a new ticket. And can you check your commands.txt: it contains only 20 turns and does not show any errors.

Concerning the original ticket, there is a garrison order turn 40965 (siege unit + other units), and then turn 40971 the same set of units is ordered to gather a shipwreck (which the siege unit can do). So I tried that, and it is reproducible: select an unpacked catapult + a few citizen soldiers, order them to garrison a fortress, and then order them to gather a shipwreck (before the catapult is packed). That will trigger an error.

[mimo]

The problem is that the MT_PackFinished message updates the orders of the old (unpacked) entity, before being copied to the new (packed) entity, so the update of the packing flag is needed. The patch here fixes the problem for me, but I have not yet checked the original replay. I'll do it later when my PC will be unused (that's a several hours replay !!) unless somebody could test it before.

[fz72]

I tested your patch with my commands.txt and the entity is now packed normal.

[mimo]

In 17305:

update packing flag, fixes #3628