#3641 closed enhancement (fixed)
[PATCH] Enable GLSL by default on OpenGL 3+
Reported by: | fabio | Owned by: | fabio |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 20 |
Component: | Core engine | Keywords: | patch |
Cc: | Patch: |
Description
Newer graphics cards should be able to properly manage GLSL, which can give better graphics not available without GLSL (windy tree, water texture, ...). This is not enabled by default anywhere, however. In r13678 GLSL was enabled, but later reverted in r13700.
The attached patch enable it by default on graphics card supporting OpenGL 3+, which should be able to properly manage GLSL (GLSL itself should be able to run with OpenGL 2+, but this patch won't force it since it may have bugs). This may eventually be tweaked if testing reveal problems (e.g. only enable on OpenGL 4+, force disable on Intel, ...).
Note for testers: remove any reference to preferglsl and gentangents in you local configuration dir before testing the patch, since local preferences have precedence.
When reviewed and applied I'll submit a patch enabling by default also advanced graphics options (e.g. materialmgr.quality = 10.0).
Attachments (2)
Change History (10)
by , 8 years ago
Attachment: | glsl-detect.patch added |
---|
comment:2 by , 8 years ago
Not to complain, really, I believe this is a good idea (and we have been way too cautious about this), but why don't you remove the "preferGLSL/GenTangents" parameters and simply use a "OpenGL Renderer" option? It would at last remove that particular ugliness.
BTW I changed the default settings the other day to quality 2.0, which already looks a lot better than 0.0
comment:3 by , 8 years ago
Maybe because of #2506 ? GenTangents and Enable GLSL are supposed to be separate. Now I would rather have a very low, low, medium, high, very high, ultra settings dropbox.
comment:6 by , 8 years ago
by , 8 years ago
Attachment: | glsl-detect.2.patch added |
---|
enable GLSL with OpenGL3+ - rebased after #2506
enable GLSL with OpenGL3+