Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#3672 closed defect (fixed)

[PATCH] Missing a "return" statement in ResourceGatherer.GetBaseSpeed

Reported by: False Vision Owned by: False Vision
Priority: Should Have Milestone: Alpha 20
Component: UI & Simulation Keywords: patch
Cc: wraitii Patch:

Description

ResourceGatherer.js line 151 is missing a return statement.

Patch attached.

Attachments (1)

m.patch (589 bytes ) - added by False Vision 5 years ago.

Download all attachments as: .zip

Change History (5)

by False Vision, 5 years ago

Attachment: m.patch added

comment:1 by stanislas69, 5 years ago

Milestone: Alpha 21Alpha 20
Owner: set to False Vision

Fixed the milestone, thanks for the patch.

comment:2 by elexis, 5 years ago

Cc: wraitii added
Keywords: review removed
Priority: Must HaveShould Have
Summary: [PATCH] Missing a "return" statement in JS.[PATCH] Missing a "return" statement in ResourceGatherer.GetBaseSpeed

As far as I can see, there are no more references to that function since r17251 (which is also the rev that introduced that mistake). If that function isn't used anywhere it should actually be removed.

wraitii should do that as he modified that class.

comment:3 by elexis, 5 years ago

Resolution: fixed
Status: newclosed

In 17349:

Remove the unused and broken function GetBaseSpeed. Fixes #3672.

comment:4 by elexis, 5 years ago

Thanks for the report!

Note: See TracTickets for help on using tickets.