#3672 closed defect (fixed)
[PATCH] Missing a "return" statement in ResourceGatherer.GetBaseSpeed
Reported by: | False Vision | Owned by: | False Vision |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 20 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | wraitii | Patch: |
Description
ResourceGatherer.js line 151 is missing a return statement.
Patch attached.
Attachments (1)
Change History (5)
by , 8 years ago
comment:1 by , 8 years ago
Milestone: | Alpha 21 → Alpha 20 |
---|---|
Owner: | set to |
comment:2 by , 8 years ago
Cc: | added |
---|---|
Keywords: | review removed |
Priority: | Must Have → Should Have |
Summary: | [PATCH] Missing a "return" statement in JS. → [PATCH] Missing a "return" statement in ResourceGatherer.GetBaseSpeed |
As far as I can see, there are no more references to that function since r17251 (which is also the rev that introduced that mistake). If that function isn't used anywhere it should actually be removed.
wraitii should do that as he modified that class.
Note:
See TracTickets
for help on using tickets.
Fixed the milestone, thanks for the patch.