Opened 8 years ago

Closed 8 years ago

#3703 closed defect (fixed)

[PATCH] The summary error!

Reported by: gameboy Owned by: elexis
Priority: Should Have Milestone: Alpha 20
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

Today, I tested the latest SVN17490, the error message appears when I finished a single game to check the menu options in the summary.

ERROR: JavaScript error: gui/session/session.js line 1 TypeError: redeclaration of const g_IsReplay @gui/session/session.js:1:1 reallyStartGame@gui/loading/loading.js:104:2

ERROR: JavaScript error: gui/summary/counters.js line 99 ReferenceError: g_Trained_Color is not defined calculateColorsTeam@gui/summary/counters.js:99:8 updatePanelData@gui/summary/summary.js:127:3 selectPanel@gui/summary/summary.js:63:2 eventhandler188 (press)@unitsPanelButton press:0:1

ERROR: JavaScript error: gui/summary/counters.js line 99 ReferenceError: g_Trained_Color is not defined calculateColorsTeam@gui/summary/counters.js:99:8 updatePanelData@gui/summary/summary.js:127:3 selectPanel@gui/summary/summary.js:63:2 eventhandler187 (press)@buildingsPanelButton press:0:1

ERROR: JavaScript error: gui/summary/counters.js line 99 ReferenceError: g_Trained_Color is not defined calculateColorsTeam@gui/summary/counters.js:99:8 updatePanelData@gui/summary/summary.js:127:3 selectPanel@gui/summary/summary.js:63:2 eventhandler187 (press)@buildingsPanelButton press:0:1

Attachments (3)

commands.txt​ (131.1 KB ) - added by gameboy 8 years ago.
t3703_summary_error.diff​ (1.1 KB ) - added by bb 8 years ago.
Solves the second error (resent cleanup renamed some const, forgot those) also added a missing semicolon.
savegame-0086.0adsave​ (501.7 KB ) - added by gameboy 8 years ago.

Download all attachments as: .zip

Change History (10)

by gameboy, 8 years ago

Attachment: commands.txt​ added

by bb, 8 years ago

Attachment: t3703_summary_error.diff​ added

Solves the second error (resent cleanup renamed some const, forgot those) also added a missing semicolon.

comment:1 by bb, 8 years ago

Component: Core engine → UI & Simulation
Keywords: patch review added
Milestone: Backlog → Alpha 20
Summary: The summary error! → [PATCH] The summary error!

comment:2 by elexis, 8 years ago

Owner: set to elexis
Resolution: → fixed
Status: new → closed

In 17492:

Correct two wrong references to variables in r17453. Patch by bb, fixes #3703.

comment:3 by elexis, 8 years ago

Keywords: review removed

Thanks for reporting and solving the bug gameboy and bb!

I can't reproduce the error about a redeclaration of const g_IsReplay and I don't see how this can happen from the code. You can reopen the ticket if you experience the error again.

comment:4 by gameboy, 8 years ago

Resolution: fixed
Status: closed → reopened

My friend, Elexis.I tested the latest SVN17496, this error occurs again, when you start a new single player, this error message appears. I uploaded my game save files.

ERROR: JavaScript error: gui/session/session.js line 1 TypeError: redeclaration of const g_IsReplay @gui/session/session.js:1:1 reallyStartGame@gui/loading/loading.js:104:2

ERROR: JavaScript error: gui/session/session.js line 1 TypeError: redeclaration of const g_IsReplay @gui/session/session.js:1:1 reallyStartGame@gui/loading/loading.js:104:2

Last edited 8 years ago by gameboy (previous) (diff)

by gameboy, 8 years ago

Attachment: savegame-0086.0adsave​ added

comment:5 by elexis, 8 years ago

I cannot reproduce this error.

Can you check if in session.js const g_IsReplay appears more than once?

Can you revert your SVN?

comment:6 by gameboy, 8 years ago

Thank you, my friend, elexis. My session.js caused a mess, I updated the file session.js again from the SVN, this error fixes, thank you very much for your help, thank you.

comment:7 by gameboy, 8 years ago

Resolution: → fixed
Status: reopened → closed
Note: See TracTickets for help on using tickets.