[PATCH] Patching SpiderMonkey for proper OpenBSD building

[David Carlier]

Hi all,

The configure script tries to detect first the presence of endian.h and sys/endian.h, both are present in OpenBSD but BYTE_ORDER is not defined rather BYTE_ORDER hence this patch ...

Hope it is useful.

Cheers.

[leper]

Was this patch submitted upstream? I'm currently working on upgrading to SpiderMonkey 38 so this patch might or might not be needed depending on the answer to that question. In any case it should be submitted upstream first.

Also read SubmittingPatches.

[David Carlier]

Ah ignored about SpiderMonkey 38's update and by having a quick look at this version this issue is fixed. Ok next time I ll look also at your suggestions, thanks for answering !

[leper]

Not entirely sure where it is failing but ​https://bugzilla.mozilla.org/show_bug.cgi?id=714312 indicates that it should work. (But since that is older than our last version it seems it doesn't. There also is a check for __BYTE_ORDER now from ​https://bugzilla.mozilla.org/show_bug.cgi?id=1065055 so it should work again)

(I should rewrite the above but given that it makes some sense now I'll leave it at that, keeping this ticket open and fixing/closing as dupe once I make a ticket for the SM38 upgrade)

[David Carlier]

Might not be entirely clear in the ticket, my fault with wrong formatting but I meant

The configure script tries to detect first the presence of endian.h and then sys/endian.h, both are present in OpenBSD but __BYTE_ORDER is not defined rather BYTE_ORDER hence this patch ...

/usr/include/endian.h is quite recent on OpenBSD (but it is just a soft link to /usr/include/sys/endian.h). I just tried to compile from source 38's version and it is fine as I expected.

[leper]

Superseded by #3708.