Opened 7 years ago

Closed 3 years ago

#3800 closed task (fixed)

List of unused technologies template (json files)

Reported by: fatherbushido Owned by: wraitii
Priority: Should Have Milestone: Alpha 24
Component: Simulation Keywords:
Cc: Patch: Phab:D1775

Description (last modified by Itms)

I list some files that are currently unused. For some/many of them, it may be intended. Morevoer it can be a bad idea to remove all of them if it's planed to use them again (related to the translation work for example).

binaries/data/mods/public/simulation/data/technologies/carthaginians/cost_celt_mercs.json binaries/data/mods/public/simulation/data/technologies/carthaginians/cost_celt_mercs_2.json binaries/data/mods/public/simulation/data/technologies/carthaginians/cost_iberian_mercs.json binaries/data/mods/public/simulation/data/technologies/carthaginians/cost_iberian_mercs_2.json binaries/data/mods/public/simulation/data/technologies/carthaginians/cost_italian_mercs.json binaries/data/mods/public/simulation/data/technologies/carthaginians/cost_italian_mercs_2.json binaries/data/mods/public/simulation/data/technologies/carthaginians/pair_celt_mercs_1.json binaries/data/mods/public/simulation/data/technologies/carthaginians/pair_celt_mercs_2.json binaries/data/mods/public/simulation/data/technologies/carthaginians/pair_iberian_mercs_1.json binaries/data/mods/public/simulation/data/technologies/carthaginians/pair_iberian_mercs_2.json binaries/data/mods/public/simulation/data/technologies/carthaginians/pair_italian_mercs_1.json binaries/data/mods/public/simulation/data/technologies/carthaginians/pair_italian_mercs_2.json binaries/data/mods/public/simulation/data/technologies/carthaginians/traintime_celt_mercs.json binaries/data/mods/public/simulation/data/technologies/carthaginians/traintime_celt_mercs_2.json binaries/data/mods/public/simulation/data/technologies/carthaginians/traintime_iberian_mercs.json binaries/data/mods/public/simulation/data/technologies/carthaginians/traintime_iberian_mercs_2.json binaries/data/mods/public/simulation/data/technologies/carthaginians/traintime_italian_mercs.json binaries/data/mods/public/simulation/data/technologies/carthaginians/traintime_italian_mercs_2.json binaries/data/mods/public/simulation/data/technologies/carthaginians/upgrade_rank_advanced_celts.json binaries/data/mods/public/simulation/data/technologies/carthaginians/upgrade_rank_advanced_iberian.json binaries/data/mods/public/simulation/data/technologies/carthaginians/upgrade_rank_advanced_italiote.json binaries/data/mods/public/simulation/data/technologies/carthaginians/upgrade_rank_elite_celts.json binaries/data/mods/public/simulation/data/technologies/carthaginians/upgrade_rank_elite_iberian.json binaries/data/mods/public/simulation/data/technologies/carthaginians/upgrade_rank_elite_italiote.json

(remains in atlas only strcuture templates/structures/cart_embassy.xml)

binaries/data/mods/public/simulation/data/technologies/hellenes/attack_inf_spearfighting.json binaries/data/mods/public/simulation/data/technologies/hellenes/temp_special_hellenization.json

binaries/data/mods/public/simulation/data/technologies/romans/decay_logistics.json

binaries/data/mods/public/simulation/data/technologies/melee_inf_sidearms.json binaries/data/mods/public/simulation/data/technologies/melee_inf_spearheads.json binaries/data/mods/public/simulation/data/technologies/pair_cav_01.json binaries/data/mods/public/simulation/data/technologies/pair_champ_02.json binaries/data/mods/public/simulation/data/technologies/pair_gather_01.json binaries/data/mods/public/simulation/data/technologies/pair_gather_02.json binaries/data/mods/public/simulation/data/technologies/pair_gather_03.json binaries/data/mods/public/simulation/data/technologies/pair_gather_wood_01.json binaries/data/mods/public/simulation/data/technologies/pair_heal_01.json binaries/data/mods/public/simulation/data/technologies/pair_heal_02.json binaries/data/mods/public/simulation/data/technologies/pair_heal_03.json binaries/data/mods/public/simulation/data/technologies/pair_house_01.json binaries/data/mods/public/simulation/data/technologies/pair_house_02.json binaries/data/mods/public/simulation/data/technologies/pair_inf_01.json binaries/data/mods/public/simulation/data/technologies/pair_inf_02.json binaries/data/mods/public/simulation/data/technologies/pair_inf_armor_01.json binaries/data/mods/public/simulation/data/technologies/pair_inf_armor_02.json binaries/data/mods/public/simulation/data/technologies/pair_inf_armor_03.json binaries/data/mods/public/simulation/data/technologies/pair_inf_armor_04.json binaries/data/mods/public/simulation/data/technologies/pair_levy_01.json binaries/data/mods/public/simulation/data/technologies/pair_siege_attack_cost.json binaries/data/mods/public/simulation/data/technologies/pair_siege_attack_pack.json binaries/data/mods/public/simulation/data/technologies/pair_siege_cost_armor.json binaries/data/mods/public/simulation/data/technologies/pair_tower_01.json binaries/data/mods/public/simulation/data/technologies/pop_civic_01.json binaries/data/mods/public/simulation/data/technologies/pop_civic_02.json binaries/data/mods/public/simulation/data/technologies/pop_house_02.json binaries/data/mods/public/simulation/data/technologies/ranged_inf_irregulars.json binaries/data/mods/public/simulation/data/technologies/ranged_inf_skirmishers.json binaries/data/mods/public/simulation/data/technologies/attack_champions_elite.json binaries/data/mods/public/simulation/data/technologies/attack_cav_lance.json binaries/data/mods/public/simulation/data/technologies/armor_infantry_hack_01.json binaries/data/mods/public/simulation/data/technologies/armor_infantry_hack_02.json binaries/data/mods/public/simulation/data/technologies/armor_infantry_hack_03.json binaries/data/mods/public/simulation/data/technologies/armor_infantry_hack_04.json binaries/data/mods/public/simulation/data/technologies/armor_infantryspearmen_pierce_01.json binaries/data/mods/public/simulation/data/technologies/armor_infantryspearmen_pierce_02.json binaries/data/mods/public/simulation/data/technologies/armor_infantryspearmen_pierce_03.json binaries/data/mods/public/simulation/data/technologies/armor_infantryspearmen_pierce_04.json binaries/data/mods/public/simulation/data/technologies/armor_cav_chamfron.json

There are also

binaries/data/mods/public/simulation/data/technologies/upgrade_rank_advanced_cavalry.json binaries/data/mods/public/simulation/data/technologies/upgrade_rank_advanced_infantry.json binaries/data/mods/public/simulation/data/technologies/upgrade_rank_elite_cavalry.json binaries/data/mods/public/simulation/data/technologies/upgrade_rank_elite_infantry.json

which are only used in

binaries/data/mods/public/simulation/templates/structures/merc_camp_egyptian.xml binaries/data/mods/public/simulation/templates/structures/ptol_mercenary_camp.xml

(atlas only structure)

binaries/data/mods/public/simulation/templates/structures/merc_camp_egyptian.xml binaries/data/mods/public/simulation/templates/structures/ptol_mercenary_camp.xml

are actually not used and replaced by

binaries/data/mods/public/simulation/templates/structures/ptol_military_colony.xml

Change History (10)

comment:1 by fatherbushido, 7 years ago

Description: modified (diff)

comment:2 by fatherbushido, 7 years ago

Description: modified (diff)

comment:3 by fatherbushido, 6 years ago

ref r18595

comment:4 by fatherbushido, 6 years ago

Description: modified (diff)

comment:5 by Imarok, 4 years ago

Component: UI & SimulationSimulation

Move tickets to Simulation as UI & Simulation got some sub components.

comment:6 by Itms, 4 years ago

Description: modified (diff)
Milestone: BacklogAlpha 24
Patch: Phab:D1775

Nescio has looked into this. The obvious downside is if we want to add back technologies in the future, but I guess they would be added with modifications anyways, and the alternative of having unmaintained unused files is not nice.

Thoughts? Maybe we could have a place where we store obsolete gameplay the same way we keep old art sources, just in case... But we should find such a place, and contrary to art rewriting some json is not a big deal.

comment:7 by Krinkle, 4 years ago

Removing them now, means they can still be recovered for inspiration or as starting point in the future, by checking them out from the older SVN or Git trees (after all, that's the power of version control).

They could still be discovered by searching through commit histories, Phabricator and Trac. For example:

Would that suffice?

comment:8 by Stan`, 4 years ago

Translations are not versioned though as Fatherbushido stated

comment:9 by wraitii, 3 years ago

Translations actually are versioned, only in .PO files. So we could recover them anytime regardless.

comment:10 by wraitii, 3 years ago

Owner: set to wraitii
Resolution: fixed
Status: newclosed

In 23770:

Delete unused technologies.

Many were 'pair' technologies, originally removed from the game in rP15713.

Patch by: Nescio

Reviewed by: wraitii

Fixes #3800

Differential Revision: https://code.wildfiregames.com/D1775

Note: See TracTickets for help on using tickets.