Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#3900 closed enhancement (fixed)

[PATCH] Seperate _kalis RMGen library

Reported by: FeXoR Owned by: FeXoR
Priority: Should Have Milestone: Alpha 21
Component: Maps Keywords: patch
Cc: _kali Patch:

Description (last modified by FeXoR)

Since most maps don't use the libs gaia.js and setup.js and to destiguish them more as a specific approach for random map generation I propose seperating them into another directory. That also avoids unneeded namespace flooding.

They are quite closely tied up so they will likely be needed both or none anyways.

Since some of the functions and the maps using them focus on multiplayer teams I propose the name mp-team.

We might want to do this for other libs as well.

Attachments (1)

seperate_rm-team.patch (52.6 KB) - added by FeXoR 3 years ago.
Patch against r18022

Download all attachments as: .zip

Change History (9)

Changed 3 years ago by FeXoR

Attachment: seperate_rm-team.patch added

Patch against r18022

comment:1 Changed 3 years ago by FeXoR

Uh, I can't find the deletion of the two moved files from rmgen so I'm not sure if that patch is correct...

comment:2 Changed 3 years ago by FeXoR

Description: modified (diff)

Sugestion from mimo: mpteam.

comment:3 Changed 3 years ago by elexis

Cc: _kali added
Milestone: BacklogAlpha 21
Summary: [PATCH] Seperate RMGen libraries to directory mp-team[PATCH] Seperate _kalis RMGen library

Just loading those libs in that case is a simple but effective improvement.

The name team isn't ideal though as it also contains functions like addBluffs which is a new way of modifying terrain (see the ambush map, for example in the alpha 20 trailer).

cc'ing _kali, maybe he has a better ieda on the naming.

comment:4 in reply to:  2 Changed 3 years ago by mimo

Replying to FeXoR:

Sugestion from mimo: mpteam.

It is rather unpleasant to be quoted like that, misrepresenting what i said in IRC. So please don't do it again. My comment on IRC was: I don't like hyphen on directory name, so IF YOU PROPOSE rm-team, then rmteam would be better. But I also said that I didn't know enough the code to propose a name, and certainly i have never mentionned mpteam.

Last edited 3 years ago by mimo (previous) (diff)

comment:5 Changed 3 years ago by FeXoR

@mimio: You are right, sorry. I didn't think this would keep someone to suggest a different name and it was not intended to do so.

sanderd17 suggested rmgen2 (just to sum up what names popped up in IRC, I don't know anything about how serious he was)

On the second thought this might be better since it doesn't say anything specific - and that's quite fitting for those mixed libs.

Last edited 3 years ago by FeXoR (previous) (diff)

comment:6 Changed 3 years ago by elexis

IMO rmgen2 would fit better. The person committing it should make sure to svn mv the files (to ensure that it detects that the files were moved, rather than a file being deleted and a new one added).

Since the code of getTeams is duplicated by many old maps, the function should remain in rmgen and other maps should be told to use them. But as that conflicts with the svn mv command, it is material for another commit.

comment:7 Changed 3 years ago by FeXoR

Resolution: fixed
Status: newclosed

In 18113:

Separate some random map libraries into a new directory. Fixes #3900

comment:8 Changed 3 years ago by FeXoR

Keywords: review removed
Note: See TracTickets for help on using tickets.