#3907 closed defect (fixed)
[PATCH] Use range based for in network code
Reported by: | elexis | Owned by: | Itms |
---|---|---|---|
Priority: | If Time Permits | Milestone: | Alpha 21 |
Component: | Network | Keywords: | patch |
Cc: | leper | Patch: |
Description
About r17730: 18:13 <@leper> and that loop could use a range based for
While wiki:Coding_Conventions only states that range-based for should be prefered over for-each, the network code exclusively uses numerical loops. This patch changes all loops in the 3 relevant network files. Disclaimer: I dont like the patch, didn't enjoy writing it, pointless churn, wasted time and don't care if it's closed as wont fix.
Attachments (2)
Change History (7)
by , 8 years ago
Attachment: | rangebasedfornetwork_v1.patch added |
---|
comment:1 by , 8 years ago
Cc: | added |
---|
by , 8 years ago
Attachment: | network_cleanup.patch added |
---|
comment:4 by , 8 years ago
Keywords: | review removed |
---|
Note:
See TracTickets
for help on using tickets.
I personally find it nice. I agree that it's never enjoyable to write such code but that's necessary if we want a tidy codebase.
Here is another version, with more cleanup and more
const
wherever possible.