Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3988 closed enhancement (fixed)

[PATCH] Move building angle from maps to libs

Reported by: FeXoR Owned by: FeXoR
Priority: Should Have Milestone: Alpha 21
Component: Maps Keywords: patch
Cc: Patch:

Description

This patch removes the constant BUILDING_ANGlE from all random maps. Some of the maps need that angle though so a variable buildingAngle is added to library.js in rmgen.

Also the parameters that usually are given that angle are made optional (and a few others e.g. so that all after an optional argument are also optional).

The "Map initialization" comments where also removed when adjacent to a changed line for there is also a logged message stating the same.

Attachments (2)

remove_BUILD_ANGlE.diff (48.4 KB ) - added by FeXoR 8 years ago.
remove_BUILD_ANGlE2.diff (49.5 KB ) - added by FeXoR 8 years ago.
Changed to const BUILDING_ORIENTATION, renamed attribute angle to orientation, moved orientation to kwargs

Download all attachments as: .zip

Change History (5)

by FeXoR, 8 years ago

Attachment: remove_BUILD_ANGlE.diff added

by FeXoR, 8 years ago

Attachment: remove_BUILD_ANGlE2.diff added

Changed to const BUILDING_ORIENTATION, renamed attribute angle to orientation, moved orientation to kwargs

comment:1 by sanderd17, 8 years ago

2nd version looks good IMO.

comment:2 by FeXoR, 8 years ago

Owner: set to FeXoR
Resolution: fixed
Status: newclosed

In 18198:

Moved BUILDING_ANGlE from the maps to BUILDING_ORIENTATION in a random map lib. Made some arguments optional with the default set to that constant, renamed some arguments and moved "orientation" in placeCivDefaultEntities to kwargs. Removed unneeded comments. Fixes #3988

comment:3 by FeXoR, 8 years ago

Keywords: review removed
Milestone: BacklogAlpha 21
Note: See TracTickets for help on using tickets.