Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#4026 closed defect (fixed)

[PATCH] Healer tooltip missing

Reported by: elexis Owned by: elexis
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

It is possible to upgrade the rate and range of healers, but it is impossible to find out their range by reading the tooltip.

There is a getHealerTooltip function used in the tech tree, but calling that from the session doesn't work natively.

Notice there is also a mauryan hero healer Chanakya that should use the same tooltip.

It should be added to

  • displaySingle of selection_details.js to complete the tooltip of a trained healer
  • g_SelectionPanels.Training of selection_panels.js to complete the tooltip of the button to train a healer

Attachments (5)

healertooltip.diff (7.5 KB) - added by fatherbushido 2 years ago.
healertooltip.2.diff (7.6 KB) - added by fatherbushido 2 years ago.
remove now useless code in st
healertooltip.3.diff (7.7 KB) - added by fatherbushido 2 years ago.
roundings
healertooltip.4.diff (7.6 KB) - added by elexis 2 years ago.
Moved tooltip above the armor tooltip, uses toFixed() and variables in tooltip.js, removes one less newline in load.js. The patch is completely broken as it doesn't change all occurances of entState.healer
healertooltip.5.diff (8.8 KB) - added by fatherbushido 2 years ago.
change name in unit_action.js

Download all attachments as: .zip

Change History (8)

Changed 2 years ago by fatherbushido

Attachment: healertooltip.diff added

comment:1 Changed 2 years ago by fatherbushido

Keywords: patch review added
Milestone: BacklogAlpha 21
Summary: Healer tooltip missing[PATCH] Healer tooltip missing
  • tooltip in training panel
  • tooltip for trained healer
  • tooltip in structure tree
  • nuke Chanakya tooltip
  • fix and make more coherent different naming in code

Changed 2 years ago by fatherbushido

Attachment: healertooltip.2.diff added

remove now useless code in st

Changed 2 years ago by fatherbushido

Attachment: healertooltip.3.diff added

roundings

Changed 2 years ago by elexis

Attachment: healertooltip.4.diff added

Moved tooltip above the armor tooltip, uses toFixed() and variables in tooltip.js, removes one less newline in load.js. The patch is completely broken as it doesn't change all occurances of entState.healer

Changed 2 years ago by fatherbushido

Attachment: healertooltip.5.diff added

change name in unit_action.js

comment:2 Changed 2 years ago by elexis

Owner: set to elexis
Resolution: fixed
Status: newclosed

In 18464:

Update healer tooltips to also show up in the selection details with actual values from the simulation. Based on patch by fatherbushido, fixes #4026.

Also clean up the Health component.
Rename healer to heal (as that is the actual component name).
Remove the structure tree code to replace a proper Templates.js implementation.

comment:3 Changed 2 years ago by elexis

Keywords: simple review removed

Thanks

Note: See TracTickets for help on using tickets.