Garrison Holder code style fixes

[Stan]

Garrison Holder has some code style issues, for example bad linebreaks, uses deprecated for each, variables out of scope, redeclared variables and the like that ought to be fixed. Most of them can be found using jshint.

[Stan]

Proposal

[bb]

Don't add new var's use let instead. This should ofc. be done in the whole file, but that should be a separate patch to avoid megapatches and make the review easier.

L378-381 no need for braces, this happens on some other places in the file too, not sure if it should be splitted.

Old L285 space error too would be nice to fix that one in same commit

[Stan]

Fix the above and and three warnings

[elexis]

If someone wants to write more cleanup patches, GUIInterface.js is changed often and JShint always complains about a range of issues.

[Stan]

Will do next.

[Stan]

Code Fixes for GUIInterface

[mimo]

updated version of the garrisonHolder cleanup

[elexis]

No tests, no cookies. The good news is that writing tests for the garrison holder should be pretty simple and I think Stan could do it :)

[Stan]

Should be nice

[Stan]

Some other stuff elexis reported

[Stan]

Fix a vector

[Stan]

Version Bump, Multiple fixes

[mimo]

Replying to elexis:

No tests, no cookies. The good news is that writing tests for the garrison holder should be pretty simple and I think Stan could do it :)

Not sure what is the expected gain compared to an independant patch with tests? this patch and the test one are independant, and as this patch is already quite big, the more we wait, the more chance we have that it will need a rebase with some chance to introduce new bugs. But ok if you take charge of it from now.

[elexis]

See @wiki:SubmittingPatches

When you modify or add methods to simulation components, you should add unit tests that test all added or modified changes. 

[elexis]

Feature freeze in 2 days.

[elexis]

(Still) Reviewable?

[Stan]

If it's not i'll rebase it later today.

[Stan]

Patch applies fine on my end.

[bb]

Component: L22 isn't "hit point" one word "hitpoint"? Shouldn't JsDoc comments have a period on the end of a sentence?

Are checks for cmpTimer actually necessary as it is a SYSTEM_ENTITY? When we should add them L261 can be change to

if (cmpTimer)
    this.timer = cmpTimer.SetTimeout(this.entity, IID_GarrisonHolder, "HealTimeout", 1000, {});

So we nuke the error

L451 missing whitespace L452 missing whitespaces, maybe meh

L517 Shouldn't we check for if (!cmpHealth)? and I guess we should {return true if the check is true. L518-9 Those variables can be inlined imo. I would keep ejectHitpoints for readability. L520 Why is that floor needed? And unneeded parenthesis.

L541-5 unneeded parenthesis. L584-7 unneeded parenthesis.

L667 var -> let L670 check for cmpPosition too.

L703 unneeded parenthesis.

IIRC some patch tools complain when there is no newline at the end of a file, so probably leave it.

Test: The test doesn't seem to test the function UnloadByPlayer and UnloadByTemplate. Might be nice too Unload some units with those functions too. (I guess we should add some more units for this.) Also GetCapacity is tested more than ones as it is called by other function too, but we now test for the exact number so I think it is ok.

L26, L27, L64, L78 arrow functions with one parameter doesn't need parenthesis.

JsHint output: binaries/data/mods/public/simulation/components/tests/test_GarrisonHolder.js: line 9, col 60, Missing semicolon. binaries/data/mods/public/simulation/components/tests/test_GarrisonHolder.js: line 12, col 51, Missing semicolon. binaries/data/mods/public/simulation/components/tests/test_GarrisonHolder.js: line 71, col 24, Don't make functions within a loop. binaries/data/mods/public/simulation/components/tests/test_GarrisonHolder.js: line 72, col 24, Don't make functions within a loop. binaries/data/mods/public/simulation/components/tests/test_GarrisonHolder.js: line 73, col 28, Don't make functions within a loop.

(those functions are false positives I guess)

[Stan]

Differential Revision:

​https://code.wildfiregames.com/D90

[elexis]

Moving to the Work In Progress milestone, since there is a patch asking for feedback, but since it is not strictly bound to a specific release.

[Imarok]

In 19927:

Garrison Holder code style fixes

Reviewed By: Imarok, bb
Refs #4102, D90

[Stan]

Looks fixed by me for me. Thanks Imarok :D