#4129 closed defect (fixed)
[PATCH] Fishing and merchant ships should be filtered when selecting military units only
Reported by: | elexis | Owned by: | fatherbushido |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 21 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | Patch: |
Description
When using the military-only-selection modifier and selecting a bunch of units, fishing ships will be added to the selection too, despite clearly not being military units.
Hotkey from default.cfg
:
milonly = Alt ; Add only military units to selection
Relevant code is in input.js
:
"isNotSupport": entity => {
The easy part is writing the code. The harder part is deciding whether there should be some !hasClass(entState, "FishingBoat")
check added to input.js
or whether the ships should receive a new class like to be filtered.
Attachments (2)
Change History (8)
comment:1 by , 8 years ago
comment:2 by , 8 years ago
Attached patch:
- fixes the issue
- uses a more coherent name (milOnly -> isMil instead of isNotSupport).
- is coherent with the todo idlewarrior hotkey
comment:3 by , 8 years ago
Keywords: | patch review added |
---|---|
Summary: | Fishing and merchant ships should be filtered when selecting military units only → [PATCH] Fishing and merchant ships should be filtered when selecting military units only |
comment:5 by , 8 years ago
Keywords: | review removed |
---|---|
Milestone: | Backlog → Alpha 21 |
comment:6 by , 8 years ago
Keywords: | simple removed |
---|
Note:
See TracTickets
for help on using tickets.
isNotSupport is use only here in the code.
I think 2. and 3.1. are the easiest solution. (but 1. would be a nice cleanup, see support elephant stuff...)