Opened 8 years ago
Closed 8 years ago
#4139 closed defect (fixed)
[PATCH] Nuke charge
Reported by: | fatherbushido | Owned by: | elexis |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 21 |
Component: | UI & Simulation | Keywords: | |
Cc: | Patch: |
Description (last modified by )
As charge is not really designed, according to some discussions on irc, it is perhaps better to nuke the remaining trace of it in the current code. The one who will implement it could do it in the way he wants.
The patch above remove all trace of it (code, templates) and change the current useless maharbal aura (it is a cavalry commander, so i move the charge attack to an hack attack bonus).
Attachments (2)
Change History (6)
by , 8 years ago
Attachment: | nukecharge.diff added |
---|
comment:1 by , 8 years ago
Description: | modified (diff) |
---|---|
Summary: | Nuke charge → [PATCH] Nuke charge |
by , 8 years ago
Attachment: | nukecharge.2.diff added |
---|
comment:2 by , 8 years ago
Keywords: | rfc removed |
---|
- in
lists.xml
is an<item>attack_charge </item>
It should be removed since there are also no actors that have that animation. - some <History> tags contain "charge", but they can stay.
- the c++ part looks fine.
- "recharge" from
cmpAttack.GetTimers()
is unused apparently and should therefore be removed
Other than that there are no occurances of "Charge" or "Charging" (case insensitive search) in *cpp, *.h, *.js, *.json, *.xml, nor /art/actors/**
Can be committed if those 2 points are addressed, thanks for the patch!
Note:
See TracTickets
for help on using tickets.
remove another TODO noticed by elexis