Opened 8 years ago

Closed 8 years ago

#4149 closed defect (fixed)

[PATCH] Capturable component test

Reported by: fatherbushido Owned by: fatherbushido
Priority: Should Have Milestone: Alpha 21
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

some basic tests of that component should be added.

Attachments (2)

capturabletest.diff​ (11.2 KB ) - added by fatherbushido 8 years ago.
thx elexis and bb for style comments
capturabletest.2.diff​ (9.9 KB ) - added by fatherbushido 8 years ago.
thx elexis and sanderd17 for remarks

Download all attachments as: .zip

Change History (9)

comment:1 by fatherbushido, 8 years ago

Fixes the message MT_CaptureRegenStateChanged too.

Last edited 8 years ago by fatherbushido (previous) (diff)

comment:2 by fatherbushido, 8 years ago

Keywords: patch rfc added
Summary: Capturable component test → [PATCH] Capturable component test

comment:3 by bb, 8 years ago

Some style review on test_Capturable.js

L44 Why id == 0 ? false : true over id != 0 Same for the functions following at L48, L52, L56

Unneeded braces at same lines.

L72 Trailing comma.

L86, L96 Make it consistent with L124 and L140.

L192 Missing whitespace.

by fatherbushido, 8 years ago

Attachment: capturabletest.diff​ added

thx elexis and bb for style comments

comment:4 by fatherbushido, 8 years ago

Keywords: review added; rfc removed

comment:5 by fatherbushido, 8 years ago

Keywords: review removed

comment:6 by fatherbushido, 8 years ago

Keywords: review added

by fatherbushido, 8 years ago

Attachment: capturabletest.2.diff​ added

thx elexis and sanderd17 for remarks

comment:7 by fatherbushido, 8 years ago

Keywords: review removed
Resolution: → fixed
Status: new → closed

fixed in r18707

Note: See TracTickets for help on using tickets.