Opened 8 years ago

Last modified 11 months ago

#4199 new enhancement

[PATCH] Merge mapSettings and InitAttributes in Simulation2.cpp — at Version 5

Reported by: Imarok Owned by:
Priority: Nice to Have Milestone: Backlog
Component: Simulation Keywords: patch
Cc: Patch:

Description (last modified by Vladislav Belov)

m_MapSettings and m_initAttributes in Simulation2.cpp should be merged, as mapSettings (normally) is initAttributes.settings

Change History (6)

by Imarok, 8 years ago

Attachment: Simulation2.cpp.patch​ added

fixes the thing. Only problem: InitGame in InitGame.js expects InitAttributes.settings being undefined when loading a map in atlas: // No settings when loading a map in Atlas, so do nothing (L29)

comment:1 by elexis, 8 years ago

Description: modified (diff)
Keywords: rfc added
Milestone: Backlog → Alpha 21

Related bug: Currently the objectives dialog throws an error when trying to open it in a running simulation inside atlas.

comment:2 by elexis, 8 years ago

Milestone: Alpha 21 → Alpha 22

Feature freeze in 2 days.

comment:3 by wraitii, 7 years ago

bump, Imarok: is the patch ready?

comment:4 by elexis, 7 years ago

Milestone: Alpha 22 → Work In Progress

Moving to the new WIP milestone.

comment:5 by Vladislav Belov, 7 years ago

Description: modified (diff)
Keywords: rfc removed

The comment above and from ​http://irclogs.wildfiregames.com/2016-11-13-QuakeNet-%230ad-dev.log: 

18:14 < Vladislav> Imarok: any progress with #4199?
18:14 < Imarok> Vladislav: I don't work on this issue anymore

So rfc removed, because: "Only hopefully committable patches should be proposed here, work-in-progress ones are discouraged."

Also atlas need to have settings to pass a data to a component (refs #3814).

Note: See TracTickets for help on using tickets.