Temple of Vesta and Wonder Temples don't have the same techs and production queues

[elexis]

The temple of vesta doesn't have the roman civ specific tech (vision range upgrade) to research. It could perhaps inherit rome_temple. Reported by javiergodas.

Some wonders are temples and received the wonder aura in r18024. These temples should also be able to train the same production queue and techs one would assume (might be nasty to implement, as one can't inherit to building types).

[fatherbushido]

I don't know if it's a good idea to produce the generic stuff in this temple (in the same way, we don't produce the same things in barracks and in gymnasium or sysitton). Perhaps allowing the healers production is ok but I m not convinced by the techs.

[elexis]

• Barracks need a tech to research champions, since barracks are cheaper than fortresses. That doesn't apply to the wonder. The implementation here would require us to either copy either the wonder or template entries to that template or implement inheriting from multiple templates, which seems like a too big task for this issue alone. So I guess we simply can't implement it without poisoning the templates.

• The temple of vesta having everything the roman temple got, but not having that one civ unique tech seems too odd to me and should be fixed IMO.

[fatherbushido]

For 2) you mean move the sybilline books tech from generic temple to the Vesta temple ? As it's a specific techs, it's can be good to move it to a specific building (needs to check if it's kinda related with vesta ?)

[elexis]

From a gameplay pov that sounds good, but I couldn't find any connection from the temple of vesta to the sybilline books.

[fatherbushido]

In fact I didn't understand. You meant vesta temple is a temple (it inherits) and can produce all the temple can excepting that special tech.

[elexis]

Any reason not to inherit rome_temple?

[fatherbushido]

You have to write the same entries (but different) so I find it less clean. But both are equal imo.

[elexis]

Sure this one isn't better?

[fatherbushido]

dunno, i found it less clean as all the entries are replacement. but that s perhaps not objective

[elexis]

So I could commit it and say reviewed by fatherbushido (not stating that you liked the patch)? X)

Everytime something is changed in rome_temple, it will have to be changed in the vesta one too, so it sounds error prone and messy to add this one entry. Most of the vesta entries are replacements, but none of them are added to cover something up. It seems unlikely that properties are added to the one temple that shouldn't also go to the vesta one.

[fatherbushido]

ok

[elexis]

In 18753:

Offer the same techs and production queue at the Temple of Vesta as are available to the general roman temple (in particular Sibylline Books tech).
Reviewed by fatherbushido, fixes #4232.

[elexis]

In 18911:

Revert r18753 as it revealed an OOS on rejoin in the engine code, refs #4232 #4316.