Explored territory outside of the map square

[elexis]

In the attached replay (alpha 21, r18802), the blue player starts with explored territory that is outside of the map area.

[elexis]

With ​Phab:D630, the area outside of the map is not explored anymore, but the area is still marked as player territory.

[elexis]

Solving this before committing ​Phab:D630 would avoid hiding this bug, making the attached replay irreproducible without reverting that commit. Maybe D630 even fixes this bug completely instead of hiding it.

D630 shows that if a CC is near the map border, the initial exploration of player territory also marks territory outside of the world as explored. That exploration is just not visible in almost all cases but this one.

If we set edgeSize in LosIsOffWorld of the CCmpRangeManager.cpp to 0 or 1 and start a square map, we will see that two sides of the minimap are being rendered that shouldn't:

So it seems we only need one stripe of explored territory to have it rendered all the way down.

Also created #4636 to make that 3 a constant and not have the territory line hidden in those 3 tiles.

[elexis]

Reproduce for belgian uplands. The repetition of the color must be some openGL thing from Minimap.cpp. Maybe ​Phab:D630 can be considered a fix even.

[elexis]

In 19790:

Fix a map exploration OOS on rejoin when starting with territory at the map boundaries.

rP9951 forgot to add a LosIsOffWorld check in ExploreTerritories (aka UpdateTerritoriesLos) and thus marked tiles outside of the world as explored.
rP13576 transformed the bug into a non-simulation desynchronization, causing rejoined players to see a different score,

as they excluded off-world tiles when filling the cache in ResetDerivedData upon rejoin.

rP19517 transformed the bug into an actual simulation OOS by serializing that map exploration percentage based on that cache.

Also tiles at the map border in square maps are not rendered as expected, so this commit hides refs #4267.

Differential Revision: ​https://code.wildfiregames.com/D630
Fixes #4598
Proofread by: Itms
Tested By: Imarok

[elexis]

Reproduce remove the LosIsOffWorld check from ExploreTerritories in CCmpRangeManager.cpp and start on Belgian Uplands with 8 players on a tiny mapsize and change the perspective to players near the map border.

It might be an OpenGL setting repeating the texture until the very end. The minimap code might need a border, potentially those 3 edge tiles described in #4636. The territory outside of the world being owned should be fixed in that ticket.

[elexis]

Calling it fixed by r19790, assuming noone cares about some OpenGL flag that should never be relevant.