Opened 7 years ago

Closed 7 years ago

Last modified 5 years ago

#4302 closed defect (fixed)

[PATCH] Disable right-click playercommands to observers

Reported by: elexis Owned by: Imarok
Priority: Must Have Milestone: Alpha 22
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

While all buttons are disabled to observers, the rightclick actions in input.js miss an observer check. It still tries to execute the command when switching the playerperspective, thus f.e. play the soundfile of units moving, or setting the rallypoint visually, while posting the sim command silently fails.

Attachments (1)

disable_observer_rightclick_v1.patch​ (947 bytes ) - added by elexis 7 years ago.

Download all attachments as: .zip

Change History (6)

by elexis, 7 years ago

Attachment: disable_observer_rightclick_v1.patch​ added

comment:1 by elexis, 7 years ago

Also the Upgrade buttons need to be disabled to observers.

comment:2 by Imarok, 7 years ago

In 18926:

Disable right-click playercommands to observers. Patch by elexis. Refs #4302.

comment:3 by Imarok, 7 years ago

Keywords: review removed

comment:4 by Imarok, 7 years ago

Owner: set to Imarok
Resolution: → fixed
Status: new → closed

In 18927:

Disable upgrade buttons to observers. Reviewed by elexis. Fixes #4302 Refs #2706

comment:5 by elexis, 5 years ago

In 22842:

Don't issue invalid move commands visualized with target markers in observermode following rP21378/D1021, refs #4791, #4302, rP18926.

Differential Revision: ​https://code.wildfiregames.com/D2210

Note: See TracTickets for help on using tickets.