Opened 7 years ago

Closed 7 years ago

#4344 closed enhancement (fixed)

[PATCH] Add function to get OpenGL error name by the code

Reported by: Vladislav Belov Owned by: Vladislav Belov
Priority: Nice to Have Milestone: Alpha 22
Component: Core engine Keywords: patch
Cc: Patch:

Description

Probably we need sometimes to print GL error name. I.e. #3996: Renderer just print the error code instead of user-friendly message.

Attachments (1)

4344_opengl.patch​ (1.9 KB ) - added by Vladislav Belov 7 years ago.
Adds the ogl_GetErrorName function

Download all attachments as: .zip

Change History (9)

by Vladislav Belov, 7 years ago

Attachment: 4344_opengl.patch​ added

Adds the ogl_GetErrorName function

comment:1 by Vladislav Belov, 7 years ago

Keywords: rfc added
Milestone: Backlog → Alpha 22

comment:2 by Vladislav Belov, 7 years ago

Summary: Add function to get OpenGL error name by the code → [PATCH] Add function to get OpenGL error name by the code

comment:3 by Vladislav Belov, 7 years ago

Status: new → assigned

comment:4 by Vladislav Belov, 7 years ago

Current ogl_WarnIfErrorLoc doesn't show the text message, only the code in the console. Also it uses debug_printf instead of LOGWARNING or LOGERROR.

comment:5 by Vladislav Belov, 7 years ago

Component: UI & Simulation → Core engine

comment:6 by Vladislav Belov, 7 years ago

Keywords: patch added

comment:7 by elexis, 7 years ago

Milestone: Alpha 22 → Work In Progress

Moving to the new WIP milestone.

comment:8 by Vladislav Belov, 7 years ago

Keywords: rfc removed
Milestone: Work In Progress → Alpha 22
Resolution: → fixed
Status: assigned → closed

Added in r19496:

Print the name of OpenGL errors when they occur. Patch by vladislavbelov Differential Revision: ​https://code.wildfiregames.com/D313

Note: See TracTickets for help on using tickets.