Opened 7 years ago

Last modified 5 years ago

#4380 new defect

Options should fallback to default when non-numerical input is given

Reported by: elexis Owned by:
Priority: Should Have Milestone: Backlog
Component: UI – Miscellaneous Keywords:
Cc: Patch:

Description

The current options page allows the user to enter arbitrary numerical values for some settings.

The min/max setting is implemented and working (f.e. observer limit), but when the user types a non-numerical or empty string, the input is not rejected but saved and passed to the code using it, causing errors in the affected components (at least the sound config).

Change History (6)

comment:1 by Vladislav Belov, 7 years ago

If #4039 would be finished (IMO, it should be finished), then the ticket will be irrelevant for the sound config.

comment:2 by fabio, 7 years ago

Thanks for working on #4039! But this issue is still relevant when manually editing config files? (somewhat related also #3737)

in reply to:  2 comment:3 by Vladislav Belov, 7 years ago

Replying to fabio:

Thanks for working on #4039! But this issue is still relevant when manually editing config files?

For sound config with sliders - no.

comment:4 by fabio, 7 years ago

I meant editing user.cfg. One can still do that other than using the sliders.

in reply to:  4 comment:5 by Vladislav Belov, 7 years ago

Replying to fabio:

I meant editing user.cfg. One can still do that other than using the sliders.

I too :P If you set sound.mastergain = "blabla" in user.cfg then you won't get any error, but value should be clamp(0, min, max).

comment:6 by Imarok, 5 years ago

Component: UI & SimulationMisc. UI

Move tickets to Misc. UI as "UI & Simulation" got some sub components.

Note: See TracTickets for help on using tickets.