Missing confirm hotkeys

[Imarok]

Some dialog buttons miss the confirm hotkey:

prelobby - would be really useful here! aiconfig - would be useful! splashscreen - absolutely missing, as it allows closing it immediately if it was read before already or wasn't cared about. Closing it with escape won't save the "read" flag, while closing with enter would. locale - would be useful to accept gamesetup - setting the confirmation button wouldn't work initially as the chat is focused, but wouldn't the "start the game with hotkey" ticket become solved with this setting, once the chat isn'T focused anymore? loadgame - would be useful msgbox - We always wanted that, but it depends on the order. So we should ping that one alpha 22 ticket we have about that in the way of adding a requirement (confirm hotkey should be set dynamically depending on the choice) credits - could map to the only button: close, even though that is accessible with escape already. loading - no user interaction, confirm hotkey can't be applied gamesetup_mp - already implemented savegame - already present, (<action on="Press"> on that text input) replaymenu - to start the replay structree - could be an alias for close lobby - not really useful as there is no obvious primary choice atlas - empty page locale_advanced - escape present, confirm not options - we mgiht refrain from assigning it to the save button in order to avoid unintentional saves when hitting enter after adding text input elements and losing focus of that element. Aboslutely missing the "close with escape" function here! summary - would be useful to continue manual - wouldn't hurt to have an alias to close the thing (in case one hand is already close the enter button, one can save few time) civinfo - same pregame - that's the mainmenu, not possible to determine a primary choice, perhaps opening the singleplayer menu, but that sounds like a handful of lines rather than one session - that won't work out

[elexis]

An empty ticket description (or review) could be compared to a triangle with 2 points. A non-empty string shows consideration, so posting one:

(For every patch, there is a way to improve and since you're asking for a review:) This patch here might be considered incomplete if there are more GUI pages where the confirm hotkey is absent (ping #3897 (focus should not be an issue as that is taken into account correctly by the engine mostly)). Since we have about a dozen of GUI pages, we can check all of them.

Dynamically setting the confirm hotkey for message boxes should be done in #4345 as it depends on the user-specified button order.

[elexis]

The diff can be committed, see refs ​D47.

The return button would be useful in other dialogs as well: prelobby - would be really useful here! aiconfig - would be useful! splashscreen - absolutely missing, as it allows closing it immediately if it was read before already or wasn't cared about. Closing it with escape won't save the "read" flag, while closing with enter would. locale - would be useful to accept gamesetup - setting the confirmation button wouldn't work initially as the chat is focused, but wouldn't the "start the game with hotkey" ticket become solved with this setting, once the chat isn'T focused anymore? loadgame - would be useful msgbox - We always wanted that, but it depends on the order. So we should ping that one alpha 22 ticket we have about that in the way of adding a requirement (confirm hotkey should be set dynamically depending on the choice) credits - could map to the only button: close, even though that is accessible with escape already. loading - no user interaction, confirm hotkey can't be applied gamesetup_mp - already implemented savegame - already present, (<action on="Press"> on that text input) replaymenu - to start the replay structree - could be an alias for close lobby - not really useful as there is no obvious primary choice atlas - empty page locale_advanced - escape present, confirm not options - we mgiht refrain from assigning it to the save button in order to avoid unintentional saves when hitting enter after adding text input elements and losing focus of that element. Aboslutely missing the "close with escape" function here! summary - would be useful to continue manual - wouldn't hurt to have an alias to close the thing (in case one hand is already close the enter button, one can save few time) civinfo - same pregame - that's the mainmenu, not possible to determine a primary choice, perhaps opening the singleplayer menu, but that sounds like a handful of lines rather than one session - that won't work out

[Imarok]

refs r19151