Unintended "Host is ready" chat message

[elexis]

The host is always considered to be ready (as he/she decides to start the game and thus implied to be ready). The "player is ready!" chat message should be seen if and only if the player has clicked the ready button. Therefore there should be no "host is ready!" chat message. After r18322, but not before sometimes, clients observed it though.

Imarok could reproduce the issue by

1. Start a host
2. Enter the gamesetup with a second client and press ready
3. Enter the gamesetup with a third client

The second client will see the "host is ready" message while the host doesn't see it.

If the a client clicks ready and another client joins, the message is seen again for all clients but not the host.

Furthermore the "ready" button of the client that clicked it still says "I'm not ready!", despite the fact of a ready reset and while the playername is not highlighted in green (which represents readiness).

[Imarok]

Both bugs are present before r18322. (Tested with r18300)

[elexis]

Sounds like r18299

[elexis]

Confirmed, sorry for the wrong assumption. There was a 1 day difference between the two commits, so not too far off.

Before r18299, resetReadyData was called likewise for both clients and server, if and only if a player disconnected and if a client joined that was a player before (EDIT: but not if a client joined who became a player by being assigned to an unused slot).

With that commit, resetReadyData is not called for the client anymore, nor called if a client joined that was a player before the rejoin.

Refs ​D50

[Imarok]

In 19215:

Reset ready state when non-observers join in gamesetup

Reviewed by: elexis

Differential Revision: ​https://code.wildfiregames.com/D50
Fixes #4452. Refs #2529. Refs rP15171, rP17443, rP18299.