Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#4606 closed defect (fixed)

undefined property g_GameAttributes.settings.Ceasefire for games with autostart

Reported by: mimo Owned by: bb
Priority: Nice to Have Milestone: Alpha 23
Component: UI & Simulation Keywords:
Cc: Patch:

Description

Start a game with (visual) autostart, and click on the ojectives button: this gives

WARNING: JavaScript warning: gui/common/gamedescription.js line 311
reference to undefined property g_GameAttributes.settings.Ceasefire
WARNING: JavaScript warning: globalscripts/l10n.js line 35
Script value conversion check failed: v.isNumber() (got type undefined)

Change History (3)

comment:1 by elexis, 6 years ago

The reason for that is that each logic change to gamesetup.js (mostly new options) must copy that to GameSetup.cpp. That's why I never came around to posting a complete patch, because if we fix the first property, the next one bugs. We also run into #4504 again. D592 is another issue related to that what was fixed when trying to deal with this ticket. (So not uploading 50% of a WIP now)

comment:2 by bb, 5 years ago

Owner: set to bb
Resolution: fixed
Status: newclosed

In 21561:

Add a ceasire autostart option, silences a javascript warning on autostart games
fixes #4606

comment:3 by bb, 5 years ago

Milestone: BacklogAlpha 23
Note: See TracTickets for help on using tickets.