Small source/GUI/ bugs

[Geramoto]

/source/gui/IGUIScrollBar.h l:212

float IsVisible() const { return GetMaxPos() != 1.f; }

i think should be

bool IsVisible() const { return GetMaxPos() != 1.f; }

/source/gui/CChart.cpp l:124

if (fabs(point.Y) != std::numeric_limits<float>::infinity() && fabs(point.Y) != std::numeric_limits<float>::infinity())

Two times Y

perhaps

if (fabs(point.X) != std::numeric_limits<float>::infinity() && fabs(point.Y) != std::numeric_limits<float>::infinity())

/source/gui/CDropDown.cpp l:331

|| (szChar >= SDLK_KP_0 && szChar <= SDLK_KP_9)))

In SDL_keycode.h, there two diffrent sequences SDLK_{x}(0,1,...8,9) and SDLK_KP_{x}(1,2,...9,0)

i think should be

|| (szChar >= SDLK_KP_1 && szChar <= SDLK_KP_0)))

[elexis]

1. looks correct
2. Vladislav or Imarok should know what should be in there. Duplicating that one condition is definitely pointless or wrong.
3. SDLK_X is for the numbers above the letters, SDLK_KP_X is for the numpad numbers. Should definitely support the former. The numpad ones could be supported as well.

[elexis]

2. Considering that there are other checks that compare X against infinity, sounds very likely that this one was intended here.

Feel free to provide a patch addressing all three issues (programming.json entry for the credits)

[elexis]

IsVisible being float instead of bool was fixed by bb in r20500.

[Imarok]

​Phab:D1072 fixes 2.

[Imarok]

In 20544:

Fix oversight in rP19408 noticed by Geramoto

Reviewed by: bb
Refs: #4722
Differential Revision: ​https://code.wildfiregames.com/D1072

[Imarok]

Move tickets to their correct component.