Issues with territory decay

[temple]

I think territories and capturing needs to be rethought, but I haven't finished working out a complete solution. (I'll post on the forum soon.) So for now here are some issues.

1. It doesn't make sense that buildings with root territory influence like cc's can be captured by territory influence, e.g. by an enemy barracks or fort dropped close enough to it. Civic centers are supposed to be creating the territories, right? See #4309. A quick fix for this is to disable territory decay for root buildings or make it less than the regeneration rate. However, the root building will still be separated from the rest of the territory, so other buildings will be disconnected and may decay.

2. Suppose A is a rooted territory, B is a rootless territory adjacent only to A, and C is a rootless territory adjacent only to B. Suppose they're all allies. Then buildings in B won't decay because they're next to an ally's rooted territory. However, buildings in C will decay because they're not next to an ally's rooted territory, even though they're next to an ally's territory that's not decaying. That doesn't seem right.

3. Enemy buildings surrounded by A quickly decay towards him. However, enemy buildings surrounded by B decay towards gaia instead of him, even though if B owned the building it would regenerate towards him. This doesn't really make sense.

4. For decaying buildings in B or C, which usually belong to gaia (since gaia can't own territory) but theoretically can be another player, there's not a check for building owner == tile owner, so the territory can blink when it shouldn't and the building can decay to the wrong neighbors. This can lead to gaia holding onto ownership of a building indefinitely with 1/300 capture points (because it decays partially towards itself), and to entertaining ownership cycles (gaia to one player, back to gaia, then a different player, and repeat).

[elexis]

4 sounds like #4681. also refs #3528 and #4384

[elexis]

refs #4787

[temple]

In 20949:

Add a tile owner check in territory decay

Differential Revision: ​https://code.wildfiregames.com/D1225
Reviewed By: mimo
Comment By: elexis
Fixes: #4787
Refs: #4681, #4749

[Imarok]

Move tickets to Simulation as UI & Simulation got some sub components.