Disconnected territory considered rooted after capturing

[elexis]

In this replay, borg- captured a barracks from Liberty at minute 13:30. The territory didn't blink and borg- was able to build a tower in that disconnected territory.

refs #3526

[elexis]

Thanks mapkoc for providing the replay.

[temple]

It was the fields that did it.

It's the same problem I described in the fourth point of #4749. There isn't a check for building owner == tile owner (in IsConnected() of TerritoryDecay.js), so while borg's barracks correctly says this territory isn't adjacent to a mutual ally so it should blink, each of Liberty's two fields say this territory is adjacent to a mutual ally so it shouldn't blink. Since the fields were built after the barracks, their "don't blink" order wins.

[elexis]

(refs ​Phab:D926)

[elexis]

Someone should check wheather it was fixed by r20268.

[elexis]

Guess it isn't fixed by that commit since it wasn't a missing update but a unintentional computation result.

[temple]

In 20949:

Add a tile owner check in territory decay

Differential Revision: ​https://code.wildfiregames.com/D1225
Reviewed By: mimo
Comment By: elexis
Fixes: #4787
Refs: #4681, #4749