Opened 7 years ago

Closed 6 years ago

#4810 closed defect (fixed)

Harbor map needs retry loop in addHarbors

Reported by: elexis Owned by:
Priority: Nice to Have Milestone: Alpha 23
Component: Maps Keywords: simple
Cc: Patch:


The createArea call in addHarbors of harbor.js either places a huge water circle of completely fails and does not place a circle.

This means that the map looks asymmetrical, the shoreline looks different in that place and that player has more territory.

There could be a retry loop that consecutively reduces the attempted area radius, or use some library function that does retry loops.

Attachments (2)

screenshot1172.jpg (186.5 KB ) - added by elexis 7 years ago.
commands.txt (1.7 KB ) - added by elexis 7 years ago.
a22 replay

Download all attachments as: .zip

Change History (3)

by elexis, 7 years ago

Attachment: screenshot1172.jpg added

by elexis, 7 years ago

Attachment: commands.txt added

a22 replay

comment:1 by Inari, 6 years ago

Milestone: BacklogAlpha 23
Resolution: fixed
Status: newclosed

[21140] seems to have fixed this by passing Infinity instead of 1 as failFraction to ps/trunk/binaries/data/mods/public/maps/random/rmgen/placer/centered/ClumpPlacer.js.

I made a few games and couldn't get it to bug. When I changed it back to 1 the harbors bugged out again.

Note: See TracTickets for help on using tickets.