Giant Jebel Barkal doesn't generate

[Shuvra]

i can't create random map in jebel barkel.it shows errors while starting it.

[elexis]

In that case it would help reporting which errors occur. But the oracle said you selected the giant mapsize, is it true? (#5150)

[Shuvra]

yes i did

[Stan]

Call stack

>	KERNELBASE.dll!_RaiseException@16
()	Unknown	Non-user code. Symbols loaded.
 	msvcr120.dll!_CxxThrowException(void * pExceptionObject=0x006dd478, const _s__ThrowInfo * pThrowInfo=0x5be6c7fc) Line 152	C++	Non-user code. Symbols loaded.
 	msvcr120.dll!operator new(unsigned int size) Line 62	C++	Non-user code. Symbols loaded.
 	pyrogenesis.exe!00039bc7()	Unknown	No symbols loaded.
 	[Frames below may be incorrect and/or missing, no symbols loaded for pyrogenesis.exe]		Annotated Frame
 	msvcr120.dll!_CallSettingFrame(unsigned long funclet=7199988, unsigned long pRN=256, unsigned long dwInCode=7198020) Line 64	Unknown	Non-user code. Symbols loaded.
 	msvcr120.dll!_CallCatchBlock2(EHRegistrationNode * pRN, const _s_FuncInfo * pFuncInfo, void * handlerAddress, int CatchDepth, unsigned long NLGCode) Line 502	C++	Non-user code. Symbols loaded.
 	msvcr120.dll!CallCatchBlock(EHExceptionRecord * pExcept=0x006dd768, EHRegistrationNode * pRN=0x006ddcf4, _CONTEXT * pContext, const _s_FuncInfo * pFuncInfo=0x003aa488, void * handlerAddress=0x00039616, int CatchDepth=0, unsigned long NLGCode=256) Line 1400	C++	Non-user code. Symbols loaded.
 	msvcr120.dll!CatchIt(EHExceptionRecord * pExcept=0x006dd768, EHRegistrationNode * pRN=0x006ddcf4, _CONTEXT * pContext=0x006dd7b8, void * pDC=0x006dd73c, const _s_FuncInfo * pFuncInfo=0x003aa488, const _s_HandlerType * pCatch=0x003aa448, const _s_CatchableType * pConv=0x5be6d1ac, const _s_TryBlockMapEntry * pEntry=0x003aa4c0, int CatchDepth=0, EHRegistrationNode * pMarkerRN=0x00000000, unsigned char IsRethrow='\0') Line 1211	C++	Non-user code. Symbols loaded.
 	msvcr120.dll!FindHandler(EHExceptionRecord * pExcept=0x006dd768, EHRegistrationNode * pRN=0x006ddcf4, _CONTEXT * pContext=0x006dd7b8, void * pDC=0x006dd73c, const _s_FuncInfo * pFuncInfo=0x003aa488, unsigned char recursive='\0', int CatchDepth=0, EHRegistrationNode * pMarkerRN=0x00000000) Line 689	C++	Non-user code. Symbols loaded.
 	msvcr120.dll!__InternalCxxFrameHandler(EHExceptionRecord * pExcept, EHRegistrationNode * pRN, _CONTEXT * pContext, void * pDC, const _s_FuncInfo * pFuncInfo, int CatchDepth, EHRegistrationNode * pMarkerRN, unsigned char recursive) Line 439	C++	Non-user code. Symbols loaded.
 	msvcr120.dll!__CxxFrameHandler(EHExceptionRecord * pExcept=0x006dd768, EHRegistrationNode * pRN=0x006ddcf4, void * pContext=0x006dd7b8, void * pDC=0x006dd73c) Line 301	C++	Non-user code. Symbols loaded.
 	ntdll.dll!ExecuteHandler2@20
()	Unknown	Non-user code. Symbols loaded.
 	ntdll.dll!ExecuteHandler@20
()	Unknown	Non-user code. Symbols loaded.
 	KERNELBASE.dll!_RaiseException@16
()	Unknown	Non-user code. Symbols loaded.
 	KERNELBASE.dll!_RaiseException@16
()	Unknown	Non-user code. Symbols loaded.
 	msvcr120.dll!_CxxThrowException(void * pExceptionObject=0x00000000, const _s__ThrowInfo * pThrowInfo=0x5be6c7fc) Line 152	C++	Non-user code. Symbols loaded.
 	msvcr120.dll!operator new(unsigned int size) Line 62	C++	Non-user code. Symbols loaded.
 	pyrogenesis.exe!00039606()	Unknown	No symbols loaded.
 	msvcr120.dll!free(void * pBlock) Line 51	C	Non-user code. Symbols loaded.
 	[Inline Frame] msvcr120.dll!_heap_alloc(unsigned int) Line 57	C	Non-user code. Symbols loaded.
 	msvcr120.dll!malloc(unsigned int size=7200064) Line 92	C	Non-user code. Symbols loaded.
 	0097002f()	Unknown	Non-user code
 	[Inline Frame] msvcr120.dll!_heap_alloc(unsigned int) Line 57	C	Non-user code. Symbols loaded.
 	msvcr120.dll!malloc(unsigned int size=27) Line 92	C	Non-user code. Symbols loaded.
 	[Inline Frame] msvcr120.dll!_heap_alloc(unsigned int) Line 57	C	Non-user code. Symbols loaded.
 	msvcr120.dll!malloc(unsigned int size=27) Line 92	C	Non-user code. Symbols loaded.
 	00000007()	Unknown	Non-user code
 	mozjs38-ps-release-vc120.dll!js::Invoke(JSContext * cx=0x2874a2f0, JS::CallArgs args={...}, js::MaybeConstruct construct=NO_CONSTRUCT) Line 491	C++	Symbols loaded.
 	mozjs38-ps-release-vc120.dll!Interpret(JSContext * cx, js::RunState & state) Line 2602	C++	Symbols loaded.
 	mozjs38-ps-release-vc120.dll!js::RunScript(JSContext * cx=0x2874a2f0, js::RunState & state={...}) Line 448	C++	Symbols loaded.
 	mozjs38-ps-release-vc120.dll!js::Invoke(JSContext * cx=0x2874a2f0, JS::CallArgs args={...}, js::MaybeConstruct construct=NO_CONSTRUCT) Line 520	C++	Symbols loaded.
 	mozjs38-ps-release-vc120.dll!js::Invoke(JSContext * cx=0x2874a2f0, const JS::Value & thisv={...}, const JS::Value & fval={...}, unsigned int argc=1, const JS::Value * argv=0x006df068, JS::MutableHandle<JS::Value> rval={...}) Line 554	C++	Symbols loaded.
 	mozjs38-ps-release-vc120.dll!JS_CallFunctionValue(JSContext * cx=0x2874a2f0, JS::Handle<JSObject *> obj={...}, JS::Handle<JS::Value> fval={...}, const JS::HandleValueArray & args, JS::MutableHandle<JS::Value> rval={...}) Line 4216	C++	Symbols loaded.

[elexis]

The fix was attached in #5150 (I noticed this error not before creating a giant mapsize for the trailer. That was fun, 10 seconds to render one frame.)

Also it can crash on a giant mapsize due to an out-of-memory error. "Normal(" size is sufficient for 8 players, setting it to more than Large is not recommended for performance reasons).

[FeXoR]

In this case the map description should say so like:

"Generating giant maps may cause the game to crash!"

[elexis]

OOM on giant mapsizes is nothing unusual, the only difference for JB is that the map starts with so many entities, whereas on other maps of giant mapsize start with one big city less. Still the player buildings can accumulate to the point of OOM (depending on pop and playeredefat). Going out of video-memory is even more likely, but all of that depends on hardware. People with 2-4GB ram are affected with smaller mapsizes and on more maps I suppose.

"Normal(" size is sufficient for 8 players, setting it to more than Large is not recommended for performance reasons).

That's the case for all maps actually.

[smiley]

To generate larger sizes, rmgen needs to use memory more efficiently. Could do stuff like ​Phab:P149. But larger sizes are pointless if the rest of the game cant keep up.

[Stan]

No progress so far on that end. so pushing

[Freagarach]

In 24617:

Fix Jebel Barkal giant.

Adjusts the jb.js to not try and place walls outside of the map.
Only adds really added walls to the entity list (refs. #5919).

Patch by: @elexis
Differential revision: D3299
Tested by: @Freagarach, @Stan
Fixes: #5177
Refs. #5150