Opened 5 years ago
#5628 new defect
Replay menu hardening against broken replays
| Reported by: | elexis | Owned by: | |
|---|---|---|---|
| Priority: | Nice to Have | Milestone: | Backlog |
| Component: | UI & Simulation | Keywords: | |
| Cc: | Patch: |
Description
As reported by ValihrAnt, some replays may be broken in some way that makes the replay menu throw errors:
WARNING: JavaScript warning: gui/replaymenu/replay_filters.js line 225 reference to undefined property replay.attribs.settings.VictoryConditions ERROR: JavaScript error: gui/replaymenu/replay_filters.js line 225 TypeError: replay.attribs.settings.VictoryConditions is undefined filterReplay@gui/replaymenu/replay_filters.js:225:1 filterReplays/g_ReplaysFiltered<@gui/replaymenu/replay_filters.js:183:49 filterReplays@gui/replaymenu/replay_filters.js:183:22 displayReplayList@gui/replaymenu/replay_menu.js:293:2 __eventhandler2655 (selectionchange)@victoryConditionFilter selectionchange:0:1 VictoryConditions is undefined filterReplay@gui/replaymenu/replay_filters.js:225:1 filterReplays/g_ReplaysFiltered<@gui/replaymenu/replay_filters.js:183:49 filterReplays@gui/replaymenu/replay_filters.js:183:22 displayReplayList@gui/replaymenu/replay_menu.js:293:2 __eventhandler2655 (selectionchange)@victoryConditionFilter selectionchange:0:1
It would be preferable to not have errors regardless of how broken the commands.txt file is.
Note:
See TracTickets
for help on using tickets.
