Opened 3 years ago

Closed 3 years ago

#5941 closed defect (fixed)

No victorious music after winning a match.

Reported by: Langbart Owned by: wraitii
Priority: Release Blocker Milestone: Alpha 24
Component: UI – In-game Keywords:
Cc: Patch: ​Phab:D3433

Description

Winning a game in the latest SVN version (24714) does not trigger victory music and only shows the options menu: "You have won! Do you want to quit?".

If I press "No" the victory music is played, if I press "Yes" I get to the summary screen, no sound is played.

Winning a game in A23b plays victorious music and shows you an options menu.

In a test macOS bundle from 14th Jan 2021, I also noticed that the sound plays very briefly (less than half a second), but stops abruptly as soon as the options menu appears.

Name&location of the music file: 0ad/binaries/data/mods/public/audio/music/You_are_Victorious!.ogg

Change History (5)

comment:1 by wraitii, 3 years ago

A23 the music actually plays before you click on any button. Clicking on 'Yes' doesn't stop it (clicking on "No" then exitting does however).

comment:2 by wraitii, 3 years ago

Priority: Should Have → Release Blocker

comment:3 by Langbart, 3 years ago

Patch: → Phab:D3433

comment:4 by Silier, 3 years ago

Owner: set to wraitii

comment:5 by wraitii, 3 years ago

Resolution: → fixed
Status: new → closed

In 24744:

Don't pause music when pausing the game / Fix victory music in SP.

Victory music doesn't work in A24 SP. That's because the modal pauses the game, and pausing the game pauses music.
This has been the case since rP13347.

Auto-pausing the game (structree, ...) didn't really happen in the past, but A24 makes it relatively common, and I think pausing the music is a bit jarring then, so this simply removes that.

Reported by: Langbart

Fixes #5941

Differential Revision: ​https://code.wildfiregames.com/D3433

Note: See TracTickets for help on using tickets.