BinarySerializer: crash when inserting an object into the GCHashMap

[Silier]

Exception:

binaryserializer.cpp(466): Assertion failed: "m_ScriptBackrefTags.put(JS::Heap<JSObject*>(obj.get()), ++m_ScriptBackrefsNext)"
wdbg_sym.cpp(91): Assertion failed: "0 && (L"FYI: WARN_IF_FALSE reports that a function failed. Feel free to ignore or suppress this warning.")"
'pyrogenesis.exe' (Win32): Loaded 'C:\Windows\WinSxS\x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.18362.1256_none_e62b6e72f8da69e8\comctl32.dll'. 
'pyrogenesis.exe' (Win32): Unloaded 'C:\Windows\WinSxS\x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.18362.1256_none_e62b6e72f8da69e8\comctl32.dll'
'pyrogenesis.exe' (Win32): Loaded 'C:\Windows\WinSxS\x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.18362.1256_none_e62b6e72f8da69e8\comctl32.dll'. 
scriptinterface.cpp(1042): Assertion failed: "0 && (L"Writing a structured clone with JS_WriteStructuredClone failed!")"

Stack trace:

>	pyrogenesis.exe!ScriptInterface::WriteStructuredClone(JS::Handle<JS::Value> v) Line 1042	C++
 	pyrogenesis.exe!ScriptInterface::CloneValueFromOtherCompartment(const ScriptInterface & otherCompartment, JS::Handle<JS::Value> val) Line 1031	C++
 	pyrogenesis.exe!JSI_Simulation::GuiInterfaceCall(ScriptInterface::CmptPrivate * pCmptPrivate, const std::wstring & name, JS::Handle<JS::Value> data) Line 59	C++
 	[Inline Frame] pyrogenesis.exe!ScriptInterface_NativeWrapper<JS::Value>::call(const ScriptRequest &) Line 74	C++
 	pyrogenesis.exe!ScriptInterface::call<JS::Value,std::wstring,JS::Handle<JS::Value>,&JSI_Simulation::GuiInterfaceCall>(JSContext * cx, unsigned int argc, JS::Value * vp) Line 124	C++
 	[External Code]	
 	[Frames below may be incorrect and/or missing]	Unknown
 	mozjs78-ps-release.dll!js::jit::MaybeEnterJit(JSContext * cx, js::RunState & state) Line 196	C++
 	mozjs78-ps-release.dll!js::RunScript(JSContext * cx, js::RunState & state) Line 450	C++
 	mozjs78-ps-release.dll!js::InternalCallOrConstruct(JSContext * cx, const JS::CallArgs & args, js::MaybeConstruct construct, js::CallReason reason) Line 620	C++
 	mozjs78-ps-release.dll!InternalCall(JSContext * cx, const js::AnyInvokeArgs & args, js::CallReason reason) Line 648	C++
 	mozjs78-ps-release.dll!js::Call(JSContext * cx, JS::Handle<JS::Value> fval, JS::Handle<JS::Value> thisv, const js::AnyInvokeArgs & args, JS::MutableHandle<JS::Value> rval, js::CallReason reason) Line 665	C++
 	mozjs78-ps-release.dll!JS_CallFunctionValue(JSContext * cx, JS::Handle<JSObject *> obj, JS::Handle<JS::Value> fval, const JS::HandleValueArray & args, JS::MutableHandle<JS::Value> rval) Line 2777	C++
 	pyrogenesis.exe!IGUIObject::ScriptEventWithReturn(const CStr8 & eventName, const JS::HandleValueArray & paramData) Line 454	C++
 	[Inline Frame] pyrogenesis.exe!IGUIObject::ScriptEventWithReturn(const CStr8 &) Line 435	C++
 	pyrogenesis.exe!IGUIObject::ScriptEvent(const CStr8 & eventName) Line 425	C++
 	pyrogenesis.exe!CGUI::SendEventToAll(const CStr8 & eventName) Line 285	C++
 	pyrogenesis.exe!CGUIManager::SendEventToAll(const CStr8 & eventName) Line 336	C++
 	pyrogenesis.exe!CGame::Update(const double deltaRealTime, bool doInterpolate) Line 405	C++
 	pyrogenesis.exe!Frame() Line 419	C++
 	pyrogenesis.exe!RunGameOrAtlas(int argc, const char * * argv) Line 685	C++
 	pyrogenesis.exe!SDL_main(int argc, char * * argv) Line 736	C++
 	[External Code]	
 	pyrogenesis.exe!CallStartupWithinTryBlock() Line 365	C++
 	[External Code]	

[Stan]

Asger crashlog is totally unrelated. #6033

[Asger]

It seems my crashlog is from that morning my bad

[Asger]

Before my 0AD closed, I got the message 'the program is not responding, do you want to close it or do you want to wait'

[wraitii]

In 24811:

Change ENSURE in BinarySerializer to try and get more debug data.

I'm hoping this will give us more information on what's going wrong.

Also remove comments which were outdated since rP24563

Refs #5987

Differential Revision: ​https://code.wildfiregames.com/D3501

[Silier]

that may be on me, I was running visual studio and I pressed break so there was no answer from my side to the server but still he should not

[Silier]

I went out and when i returned i found this one, no idea what happened before that: Assertion failed: "0 && (L"FYI: WARN_IF_FALSE reports that a function failed. Feel free to ignore or suppress this warning.")"

Location: wdbg_sym.cpp:91 (InitDbghelp)

Call stack:

While generating an error report, we encountered a second problem. Please be sure to report both this and the subsequent error messages.

errno = 12 (Not enough memory)

OS error = 8 (Zur Verarbeitung dieses Befehls sind nicht genügend Speicherressourcen verfügbar.)

[wraitii]

Hm, this reads like the hardware detection failed?

[wraitii]

We've been rather unable to reproduce this issue, and it shouldn't crash any more, so I'm downgrading this from RB to must have. I think it's unlikely we'll get more info/fix it if there is indeed an issue in A24

[Stan]

Unlikely to get done for A26

[Freagarach]

Pushing back.