Opened 3 years ago

Last modified 3 years ago

#6204 closed defect

Gamesetup bugs. — at Initial Version

Reported by: Imarok Owned by:
Priority: Release Blocker Milestone: Alpha 25
Component: UI – Game setup Keywords:
Cc: wraitii Patch:

Description

Bug 1: When joining as observer you still have a ready button
Reproduce:

  1. Host a gamesetup
  2. choose a random map and set to 1 player
  3. join with another client

Result:
joined client is an observer but has a ready button. When pressing that it throws this error:

ERROR: Errors executing script event "Tick"
ERROR: JavaScript error: gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessages/ClientChat.js line 36
color is undefined
  colorizePlayernameByGUID@gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessages/ClientChat.js:36:20
  onClientLeave@gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessages/ClientConnection.js:21:24
  onPlayerAssignmentMessage@gui/gamesetup/Controllers/PlayerAssignmentsController.js:145:13
  pollPendingMessages@gui/gamesetup/NetMessages/NetMessages.js:42:13
  onTick@gui/gamesetup/SetupWindow.js:106:29
  @gui/gamesetup/SetupWindow.js:57:64

Expected: observers don't have a ready button.

Bug 2: player slots appearing out of nothing
Reproduce:

  1. Host gamesetup as player A
  2. choose a random map and set to 1 player
  3. Join with another client as player B
  4. Assign the slot of to player B

Result:
The player list is broken for player A and player B suddenly sees two player slots.
Screen of player A:
Screen of player B:

Expected:
Just swap the players.

Both bugs where probably introduced with rP25077 or rP25096.

Change History (3)

by Imarok, 3 years ago

Attachment: screenshot0107.png added

by Imarok, 3 years ago

Attachment: screenshot0108.png added

by Imarok, 3 years ago

Attachment: screenshot0106.png added
Note: See TracTickets for help on using tickets.