Opened 3 years ago

Closed 3 years ago

#6205 closed defect (fixed)

Incorrect save options popup

Reported by: Stan Owned by: wraitii
Priority: Release Blocker Milestone: Alpha 25
Component: UI – Miscellaneous Keywords:
Cc: Patch: ​Phab:D4170

Description

There at least two bugs in the options menu + #6197

The first one was reported by Freagarach, sometimes when opening and closing the menu you will get a confirmation dialog while you change nothing.

It could be that a hook is forcing an option to off/on, but the value is not registered in the config file, or is different from the one in the config

The second one happens if you set an option back and forth, eg GLSL on, set it to false, set it back to on, you get a confirmation popup asking you whether you'd like to save your changes.

Change History (4)

comment:1 by wraitii, 3 years ago

The first is a real bug, the second is not IMO, though it would be good if it didn't happen.

comment:2 by Freagarach, 3 years ago

Priority: Must Have → Release Blocker

comment:3 by Stan, 3 years ago

Patch: → Phab:D4170

comment:4 by wraitii, 3 years ago

Owner: set to wraitii
Resolution: → fixed
Status: new → closed

In 25802:

Fix options occasionally thinking they've been modified when they haven't.

std::array leave the values in an undefined state which can very well be 'true'.

Tested By: Freagarach

Fixes #6205

Differential Revision: ​https://code.wildfiregames.com/D4170

Note: See TracTickets for help on using tickets.