Opened 3 years ago

Closed 2 years ago

#6346 closed defect (fixed)

Check compatibility with macOS 12

Reported by: Langbart Owned by: Langbart
Priority: Should Have Milestone: Alpha 26
Component: Core engine Keywords:
Cc: Patch: ​Phab:D4320

Description (last modified by Langbart)

The file FixMacBuild.diff in the spidermonkey folder was added with [24644] and contained sdk_max_version = Version('11.99'), with macOS 12 this might not work anymore.

It could be as simple as increasing the number to solve the problem.

Create the ticket so that the problem is not forgotten.

Related ​IRC 0ad-dev conversation (29/Sep/21) 

07:58 < Langbart> do we need to update the FixMacBuild file for macOS 12?
07:58 < Langbart> atm it is set at 11.99
08:05 < wraitii> mhh
08:06 < wraitii> maybe
08:06 < wraitii> re they releasing it as MacOS 12 or just 11.1 ?
08:06 < wraitii> oh yeah it's 12

Change History (3)

comment:1 by Langbart, 3 years ago

Description: modified (diff)

Added a related IRC conversation to the description.

comment:2 by Langbart, 3 years ago

Owner: set to Langbart
Patch: → Phab:D4320

adding patch number

comment:3 by wraitii, 2 years ago

Resolution: → fixed
Status: new → closed

In 26190:

Remove the macOS SDK maximum version check

Upstream Spidermonkey has removed the SDK maximum version check ( ​https://bugzilla.mozilla.org/show_bug.cgi?id=1707953 )
Our patch added in rP24644 is broken on MacOs 12 and it seems logical to follow upstream in simply removing the check.

Patch by: Langbart

Reviewed By: wraitii

Closes #6346

Differential Revision: ​https://code.wildfiregames.com/D4320

Note: See TracTickets for help on using tickets.