Selection shapes decouple from units

[Langbart]

An issue was reported via IRC 0ad-dev ​26/Apr/22 by wowgetoffmang

04:02 < Langbart> [...] What is the issue with the ships ?
04:12 < wowgetoffmang> It was in Atlas that I couldn't see the selection shape for ships.
04:15 < wowgetoffmang> lol...
04:15 < wowgetoffmang> Selection shapes decouple from units
...
05:18 < Langbart> does the ship issue happens consistently or was it a one time thing ?
05:26 < wowgetoffmang> k thnx. I saw it happen with ships and als briefly with land units in a  different match

reproducible

Edit (27/Apr/22)

• see comment:1
  • Alternatively, download both files findme.pmp and findme.xml and place them in your binaries/data/mods/public/maps/scenarios folder
  • Start the map from the GUI or via the command line

    binaries/system/pyrogenesis -conf=mod.enabledmods:"mod public" -autostart="scenarios/findme"
    

  • After opening the map, move the units/athen/ship_merchant the problem described above should become apparent.

• small discussion on IRC 0ad-dev ​26/Apr/22

21:05 < Vladislav> Meh, https://imgur.com/a/wMIAExM
21:06 < Langbart> looks similar to what i did
21:07 < Langbart> https://code.wildfiregames.com/F2671570
21:10 < Vladislav> Not exactly, you lifted up the water for the whole map.
21:12 < Langbart> ok you win.
21:12 < Langbart> it does make a difference
21:21 < Vladislav> It might be related to passability updates.

bisect

[26815]

[Vladislav Belov]

I need following steps to reproduce:

1. Open Atlas and add some water to the default map (with terrain tool and pick water height tool)
2. Select movement tool and place a ship (Player 1)
3. Start simulation
4. Move with the movement tool the ship a bit
5. Select the default tool and order the ship to move

[Langbart]

adding a test map

[Langbart]

bisect

[Vladislav Belov]

In 26833:

Adds backend buffer upload forgotten in rP26815. Fixes #6520