Requirement tooltip errors for Ptolemaic barracks

[Langbart]

to reproduce

• start map with ptol
• build && select a Barrack
• errors
• the Royal Guard Infantry has two requirements phase_city and unlock_champion_infantry

errors

ERROR: JavaScript error: gui/common/l10n.js line 69
Script value conversion check failed: v.isString() || v.isNumber() || v.isBoolean() (got type undefined)
  translate@gui/common/l10n.js:69:36
  getRequirementsTooltip@gui/common/tooltips.js:975:23
  setupButton@gui/session/selection_panels.js:1051:4
  setupUnitPanel@gui/session/unit_commands.js:94:35
  updateUnitCommands@gui/session/unit_commands.js:152:18
  updateSelectionDetails@gui/session/selection_details.js:537:20
  updateGUIObjects@gui/session/session.js:730:2
  onSimulationUpdate@gui/session/session.js:680:2
  __eventhandler6 (SimulationUpdate)@session SimulationUpdate:1:1
ERROR: Errors executing script event "SimulationUpdate"

bisect

likley [27245]

possible solution

binaries/data/mods/public/simulation/templates/units/ptol/champion_infantry_pikeman.xml

@@ -8 +8 @@
     <Icon>units/ptol/champion_infantry.png</Icon>
     <Requirements>
       <Techs datatype="tokens">unlock_champion_infantry</Techs>
+      <Tooltip>Ask Freagarach</Tooltip>
     </Requirements>
   </Identity>
   <VisualActor>

related ticket to requirement feature

#6705

[Freagarach]

[27505] I'll commit the proposed fix. ;P

Hmm maybe not.

[Freagarach]

In 27524:

Fix multiple requirements (and no tooltip) of the Ptol champion pikeman.

Reported by: @Langbart
Fixes #6724

[Langbart]

okay, this works. other templates do it like this:

sele/champion_infantry_swordsman.xml​

Line
7	<SpecificName>Thorakitès Rhomaïkós</SpecificName>
8	<Icon>units/sele/champion_swordsman.png</Icon>
9	<Requirements>
10	<Techs datatype="tokens">-phase_city reformed_army_sele</Techs>
11	</Requirements>
12	</Identity>
13	<VisualActor>

---

I'm more concerned about how to spot this issue before it's released, I just happened to stumble across it, it severely affects gameplay, even partially prevents the production of new units in completely different buildings.

[Freagarach]

Yeah, we can either remove the datatype (so it doesn't merge the tokens) or remove the earlier tech. The latter might be better.

---

It is indeed hard to spot, I've manually checked the templates before [27505], but playing reveals them more easily.

[Langbart]

If you play latest delenda est it suffers from the same problem. Simply selecting the soldier disables the game.

• fresh commit ~13hrs ago ​JustusAvramenko/delenda_est - Requirement fixes - e65aa59

---

warning ?

binaries/data/mods/public/gui/common/tooltips.js

@@ -972 +972 @@
         return objectionFont(sprintf(translate("Requires %(technology)s"), {
             "technology": getEntityNames(GetTechnologyData(requirements.Techs._string, civ))
         }));
-    return objectionFont(translate(requirements.Tooltip));
+    if ("Tooltip" in requirements)
+        return objectionFont(translate(requirements.Tooltip));
+    return warn(`Multiple Tech requirements found - ${requirements.Techs._string.replace(/\s/,",")}, but no "<Tooltip>...</Tooltip>" specified`)
 }
 
 /**

---

EDIT:

• at least check for undefined
  • wiki/Coding_Conventions#JavaScript

  Always check for undefined properties and/or invalid object references, if it's possible they could occur.

[Freagarach]

In 27530:

Properly use tokens for all Tech requirements.

Better than faking the fix with a flaw in the inheritance.
Refs. r27524 / rP27524 and r27505 / rP27505.

Differential revision: ​https://code.wildfiregames.com/D4924
Comments by: @Stan
Refs. #6724

[Freagarach]

In 27531:

Don't error out on complex requirements without tooltip.

Since it is not nice to make the game unusable (citation needed) we'll emit a warning, which is less not nice.
Reported by: @Langbart

Differential revision: ​https://code.wildfiregames.com/D4930
Reviewed by: @Langbart
Fixes #6724