Allow mirage exception for relics in fog-of-war

[Langbart]

to reproduce

• start map with relics, explore the map till you find one
• move away till the relic disappears in the FOW (fog-of-war)
• notice relic is hidden again

expected behavior

• relic gets a mirage
• simulation/components/Mirage​
  
  • Mirage entities replace real entities in the fog-of-war.

Timeline

• Fogging added for buildings [15612] (5/Aug/14)
• Introduction of Capture the Relic [19345] (25/Mar/17)

possible solution

see comments

[Stan]

Does this template property do what you want ? ​https://github.com/0ad/0ad/blob/c0d5e9a21aad7880a1446e951efc957c8275588e/binaries/data/mods/public/simulation/templates/gaia/fauna_camel_trainable.xml#L8

[Langbart]

Yes, but actually no. I see through the FOW that the relic moves when the enemy captures it. I shouldn't be able to.

binaries/data/mods/public/simulation/templates/template_unit_catafalque.xml

@@ -58 +58 @@
   <VisualActor>
     <Actor>units/global/catafalque.xml</Actor>
   </VisualActor>
+  <Visibility>
+    <RetainInFog>true</RetainInFog>
+  </Visibility>
 </Entity>

---

This is what I want!

binaries/data/mods/public/simulation/templates/template_unit_catafalque.xml

@@ -1 +1 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Entity parent="template_unit">
+  <Fogging/>
   <Capturable>
     <CapturePoints>250</CapturePoints>
     <GarrisonRegenRate>0</GarrisonRegenRate>
@@ -58 +59 @@
   <VisualActor>
     <Actor>units/global/catafalque.xml</Actor>
   </VisualActor>
+  <Visibility>
+    <RetainInFog>true</RetainInFog>
+  </Visibility>
 </Entity>

---

• Can fogging and miraging be used interchangeably to describe the same thing, is there any difference?
• Why do I only have to add ​<Fogging/> and not also ​<Mirage/> ?

[Freagarach]

See also ​Phab:D1997.

I guess they can be used interchangeably, at least we'll understand. :)

The Mirage component is added by the filter in Fogging:LoadMirage.

[Langbart]

The above template change is not enough to solve this problem.

• several problems noticed:
  • If a relic is visible in the FOW but has been moved by the enemy (blue player), the red player moves in the direction of the relic until red has visible confirmation that the relic is no longer in its scouted location, but then immediately moves in the correct direction (red should move to the FOW location and become idle as it can't know the new location of the relic) UNITAI issue
  • note that the mirage of the FOW relic is not erased for red FOGGING/MIRAGE issue

---

Replying to Freagarach:

See also ​Phab:D1997.

Good diff reference.