Opened 12 months ago

Closed 12 months ago

Last modified 11 months ago

#6806 closed defect (fixed)

Incorrect Translations for timers

Reported by: berhudar Owned by: Stan
Priority: Should Have Milestone: Alpha 27
Component: Internationalization & Localization Keywords:
Cc: Patch:

Description (last modified by Stan)

Timers use format string such as HH:mm:ss HH:mm and mm:ss` Those should not be translated but their format might differ betwen countries. E.g. one could write 10:00 for ten minutes remaining, or 10 00 or 10-00. One solution could be to replace the specifier by %hours:%minutes:%seconds allowing only the separator to be changed.

Attachments (9)

tr_timer_bug_in_the_lobby.PNG (1005.3 KB ) - added by berhudar 12 months ago.
That happens since i started to play this game ~2 years, dunno if it was exist before.
ss_replaymenu.rar (1.7 MB ) - added by berhudar 12 months ago.
Same TR (Türkçe) timer issue with another page and its in the replay menu as you can see.
in-game_timer_bugs_all.png (1.2 MB ) - added by berhudar 12 months ago.
timer_bug_for_game-time_but_fixed-date.png (944.2 KB ) - added by berhudar 12 months ago.
timer_bug_top_left_little_section_list.png (943.9 KB ) - added by berhudar 12 months ago.
replay-menu_timer-test.png (1.1 MB ) - added by berhudar 12 months ago.
lobby_timer-test.PNG (864.4 KB ) - added by berhudar 12 months ago.
in-game_timer-test.png (1.8 MB ) - added by berhudar 12 months ago.
fixed_tr_wrong_translation_format.rar (116.6 KB ) - added by berhudar 12 months ago.

Change History (34)

by berhudar, 12 months ago

That happens since i started to play this game ~2 years, dunno if it was exist before.

comment:1 by berhudar, 12 months ago

Description: modified (diff)

comment:2 by Stan, 12 months ago

Description: modified (diff)

by berhudar, 12 months ago

Attachment: ss_replaymenu.rar added

Same TR (Türkçe) timer issue with another page and its in the replay menu as you can see.

comment:3 by berhudar, 12 months ago

Component: Core engineUI & Simulation

comment:4 by Stan, 12 months ago

I checked for bad translations on Transifex, but it does not seem to be the case.

comment:5 by berhudar, 12 months ago

If i am not wrong when i had an forums account i also posted this bug there, Vladislav Belov found the issue but when i delete my forums account the all post releated to the post automaticly deleted unfortunately. Maybe he can help. It's a really annoying issue when you play this game at top level and because of this bug i can not play the game in my native language. All messages are not sent at the same time and log entries are not in same time. Take it easy for everyone.

That happens since i started to play this game ~2 years, dunno if it was exist before.

comment:6 by Vladislav Belov, 12 months ago

That happens because translations are incorrect (SS:dd instead of HH:mm). It happens not only in Turkish language.

by berhudar, 12 months ago

Attachment: in-game_timer_bugs_all.png added

in reply to:  6 comment:7 by berhudar, 12 months ago

Replying to Vladislav Belov:

That happens because translations are incorrect (SS:dd instead of HH:mm). It happens not only in Turkish language.

I changed all "HH:mm" with "SS:dd" as you said and it fixed replay menu date column but still buggy in game timer column and in-game's itself timers for game time, ceasefires, relics... etc. What do you suggest to do in that situation?

In this game just 2 seconds passed but you can see the result

In this page at top left you can see little section list is also buggy at top left

C:\Users\ISIK\Documents\My Games\0ad\screenshots

Last edited 12 months ago by berhudar (previous) (diff)

comment:8 by Stan, 12 months ago

You have to look for mm:ss as well as HH:mm:ss. Turkish had dd:ss which was wrong.

I fixed all the translations I could find, they should be updated in SVN Friday morning (GMT).

https://app.transifex.com/wildfire-games/search/?q=source_text%3A%27%5BHH%3Amm%3Ass%5D%27

https://app.transifex.com/wildfire-games/search/?q=source_text%3A%27%5Bmm%3Ass%5D%27

https://app.transifex.com/wildfire-games/search/?q=source_text%3A%27%5BHH%3Amm%5D%27

Last edited 12 months ago by Stan (previous) (diff)

in reply to:  8 comment:9 by berhudar, 12 months ago

Replying to Stan:

You have to look for mm:ss as well as HH:mm:ss. Turkish had dd:ss which was wrong.

I see.

I fixed all the translations I could find, they should be updated in SVN Friday morning (GMT).

Thanks.

https://app.transifex.com/wildfire-games/search/?q=source_text%3A%27%5BHH%3Amm%3Ass%5D%27

https://app.transifex.com/wildfire-games/search/?q=source_text%3A%27%5Bmm%3Ass%5D%27

https://app.transifex.com/wildfire-games/search/?q=source_text%3A%27%5BHH%3Amm%5D%27

comment:10 by Stan, 12 months ago

Component: UI & SimulationInternationalization & Localization
Description: modified (diff)
Keywords: timer bug removed
Summary: Timer BugIncorrect Translations for timers

comment:11 by Stan, 12 months ago

Patch: a27 RC

Patch should be used for Phab:DXXX differentials

comment:12 by berhudar, 12 months ago

Cc: berhudar removed

comment:13 by Stan, 12 months ago

Owner: set to Stan

Fixed in r27653

comment:14 by Stan, 12 months ago

Resolution: fixed
Status: newclosed

comment:15 by berhudar, 12 months ago

Mr Stan the fixes are not enough for the Turkish language because its not just an error of [HH:mm] combination, it also contains [year, month], [year, month, day], [HH:mm:ss] etc. so for Turkish language ( dakika(dd) means minute(mm) ) and when i search for "dd" except one file full of word "Add" i was easily able to catch the typos and fixed (also fixed the file full of word "Add"). I am not sure is it the case for the other languages but thank you for your effort to fix all typos that you detected in translation files. I can upload the files here but not sure how to add just changes instead of whole files just like you did. Take it easy.

comment:16 by Stan, 12 months ago

I'm sorry I do not quite understand what you mean, this ticket was about timers and hours and all of the them are fixed by using the english symbols for hours minutes and seconds.

If there are more, you can create another ticket. Ideally you need to fix them here: https://app.transifex.com/wildfire-games/0ad/language/tr/

by berhudar, 12 months ago

Attachment: replay-menu_timer-test.png added

by berhudar, 12 months ago

Attachment: lobby_timer-test.PNG added

by berhudar, 12 months ago

Attachment: in-game_timer-test.png added

in reply to:  16 comment:17 by berhudar, 12 months ago

Replying to Stan:

I'm sorry I do not quite understand what you mean, this ticket was about timers and hours and all of the them are fixed by using the english symbols for hours minutes and seconds.

If there are more, you can create another ticket. Ideally you need to fix them here: https://app.transifex.com/wildfire-games/0ad/language/tr/

I dont know how can i explain more but i can show the difference between your fixes committed by vladislav belov which i have done already before you post and my fixes based on his comitmment. Here the changes i have done before with same way your fixes:

Replying to Vladislav Belov:

That happens because translations are incorrect (SS:dd instead of HH:mm). It happens not only in Turkish language.

I changed all "HH:mm" with "SS:dd" as you said and it fixed replay menu date column but still buggy in game timer column and in-game's itself timers for game time, ceasefires, relics... etc. What do you suggest to do in that situation?

In this game just 2 seconds passed but you can see the result

In this page at top left you can see little section list is also buggy at top left

C:\Users\ISIK\Documents\My Games\0ad\screenshots


And here after i have done my fixes:


As you can see timer bugs releated to wrong translation formats have been fixed.

comment:18 by Stan, 12 months ago

Alright that just means the date is wrong, but that's a different issue from the timers. It needs to be fixed too.

You can find the strings like so https://app.transifex.com/wildfire-games/search/?q=source_text%3Ayyyy+translated%3Ayes

in reply to:  18 comment:19 by berhudar, 12 months ago

Replying to Stan:

You can find the strings like so https://app.transifex.com/wildfire-games/search/?q=source_text%3Ayyyy+translated%3Ayes

Thanks for the link, I have added the missing fixes there as best i can

Last edited 12 months ago by berhudar (previous) (diff)

comment:20 by berhudar, 12 months ago

But will be they approved immediately before the a27 RC2 ?

comment:21 by Stan, 12 months ago

They will be updated Monday. I don't think I will make a new RC this weekend. It depends if many fixes are committed or not.

comment:22 by berhudar, 12 months ago

Okay. Stan can you make me an approver for Turkish Language in Transifex? I am translating the new strings and old defective translations.

comment:23 by Stan, 12 months ago

Done.

comment:24 by berhudar, 12 months ago

Thanks.

comment:25 by berhudar, 11 months ago

Stan i have completed all the missing translations in Turkish Language and now its one of the fully translated languages in the list. I also fixed some defective translations but right now i can not see the changes when i edit a String. Is there a way to see the changes of correct form of defective translations on live when i translate via transifex and running 0ad at the same time?

Last edited 11 months ago by berhudar (previous) (diff)
Note: See TracTickets for help on using tickets.