MacOS libzip compile error with premake / update-workspace.sh

[John-Mason Shackelford]

Attempting to build from master on OS X, having addressed the issue described in track #6797, the following error occurs when running ./update-workspace as described in ​https://trac.wildfiregames.com/wiki/BuildInstructions#Buildthegame

$ ./clean-workspaces.sh 
Cleaning bundled third-party dependencies...
.....
Removing generated stub and test files...
Cleaning build output...

Done. Try running update-workspaces.sh again now.
$ export
export HOMEBREW_CELLAR="/usr/local/Cellar"
export HOMEBREW_PREFIX="/usr/local"
export HOMEBREW_REPOSITORY="/usr/local/Homebrew"
export INFOPATH="/usr/local/share/info:"
export LANG="en_US.UTF-8"
export MANPATH="/usr/local/share/man::"
export OLDPWD
export PATH="/usr/local/bin:/usr/local/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Users/jpshack/code/arcanist/bin/"
export PWD="/Users/jpshack/code/0ad-jpshack/build/workspaces"
export SHELL="/bin/zsh"
export SHLVL="2"
export SSH_AUTH_SOCK="/private/tmp/com.apple.launchd.p1bbgQiJIy/Listeners"
export TERM="xterm-256color"
export TERM_PROGRAM="Apple_Terminal"
export TERM_PROGRAM_VERSION="447"
export XPC_FLAGS="0x0"
export XPC_SERVICE_NAME="0"
export __CFBundleIdentifier="com.apple.Terminal"

$ ./update-workspaces.sh 
==== Building lua-lib (release) ====
==== Building zip-lib (release) ====
Creating obj/Release/lua-lib
lapi.c
Creating obj/Release/zip-lib
mkstemp.c
../../contrib/libzip/mkstemp.c:76:8: error: call to undeclared function 'getpid'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        pid = getpid();
              ^
1 error generated.
make[1]: *** [obj/Release/zip-lib/mkstemp.o] Error 1
make: *** [zip-lib] Error 2
make: *** Waiting for unfinished jobs....
.....
Linking lua-lib
ERROR: Premake build failed

[John-Mason Shackelford]

Also reported by @real_tabasco_sauce in ​https://code.wildfiregames.com/D5092#216546

[John-Mason Shackelford]

Interestingly ​https://zlib.net reports that zlib is already included in MacOS.

Also seeing that in ​https://github.com/fjg/zipruby/issues/5 others are finding that they need to pass via CFLAGS -Wno-error=implicit-function-declaration .

[John-Mason Shackelford]

I am able to complete ./update-workspace with the patch in ​https://code.wildfiregames.com/D5093.

[Ralph Sennhauser]

Upstream bug: https://github.com/premake/premake-core/issues/2092