Ticket #504: shadow_culling_frustum_adjust.patch

GameView.cpp

@@ -70 +70 @@
 const float CGameView::defaultFOV = DEGTORAD(20.f);
 const float CGameView::defaultNear = 4.f;
 const float CGameView::defaultFar = 4096.f;
+const float CGameView::defaultCullFOV = CGameView::defaultFOV + DEGTORAD(6.0f); //add 6 degrees to the default FOV for use with the culling frustum
 
 class CGameViewImpl : public CJSObject<CGameViewImpl>
 {
@@ -310 +311 @@
 
         // This can be uncommented to try getting a bigger frustum.. 
         // but then it makes shadow maps too low-detail.
-        //m_CullCamera.SetProjection(1.0f, 10000.0f, DEGTORAD(30));
-        //m_CullCamera.UpdateFrustum();
+        // 
+        // Xin: I'm not sure what the previous comment is referring to with shadow maps becoming too low-detail,
+        // but one way to fix shadows popping in at the edge of the screen is to widen the culling frustum so that 
+        // objects aren't culled as early. The downside is that objects will get rendered even though they appear
+        // off screen, which is somewhat inefficient. A better solution would be to decouple shadow map rendering
+        // from model rendering; as it is now, a shadow map is only rendered if its associated model is to be
+        // rendered.
+        m->CullCamera.SetProjection(defaultNear, defaultFar, defaultCullFOV);
+        m->CullCamera.UpdateFrustum();
     }
     g_Renderer.SetSceneCamera(m->ViewCamera, m->CullCamera);
 

GameView.h

@@ -42 +42 @@
 {
     NONCOPYABLE(CGameView);
 public:
-    static const float defaultFOV, defaultNear, defaultFar;
+    static const float defaultFOV, defaultCullFOV, defaultNear, defaultFar;
 
 private:
     CGameViewImpl* m;