[PATCH] Changing selection in actor viewer should display correct player colour

[historic_bruno]

If you change selections in the object panel with actor viewer open, the player colour of the displayed entity becomes grey, but it should match the colour of the selected player. Probably this involves sending a player ID in the SetActorViewer message (because the AtlasUI is in a separate thread from the engine and they communicate by messages), and then getting the player colour however it's done in other parts of the engine. If you select a player after switching actors, the colour updates correctly, so this is only a problem when switching actors.

[Mitchell K]

I gave this a try, it certainly took a long time as I'm still learning the codebase. I think I implemented it in the way described in the description.

[historic_bruno]

The patch looks good, there's just one thing I would change.

The actual simulation code for switching actors is in ​ActorViewer::SetActor(), so I think ownership should be set there as well (instead of ​GraphicSetupHandlers.cpp).

[Mitchell K]

Good observation, that seems much better to me. Here's the revised patch.

[Mitchell K]

entity ownership code moved to ​ActorViewer::SetActor?() and fixes assuming default is gaia

[ben]

In 11527:

Fixes player colors in actor viewer, based on patch by mk12. Fixes #1022.