Bounding box changes broke farm selection

[Kieran P]

After the awesome changes to the bounding box selection, it seems farms are no longer selectable via single click. You need to drag select them. Bug in the code or just missing an XML on the entity?

[vts]

(In [10598]) Hotfix for broken field selection boxes. Closes #1030.

[vts]

Bug in the code or just missing an XML on the entity?

A little bit of both, probably. The issue is that the fields consist almost entirely of a decal, which are excluded from the recursive selection bounds by default. It usually makes sense to exclude them, except of course in this case.

The solution I've committed is to set the fields to use their footprint boxes as their selection boxes, hence no longer depending on the recursive bounds calculation.

From this issue, the comments by ben on #914 and from people on IRC it is now clear that we need more fine-grained control over what is included in or excluded from the selection boxes. For example, I recall comments on IRC saying that the spears of some infantry units should not contribute to the box because they make them a bit too large. Similarly, in this case, the decals should have been included instead of excluded.

Considering additionally that we might also need to define the selection shapes at the actor level instead of the entity level, I suggest to discuss this on the next dev meeting and create a new ticket for the further improvements we decide upon.

[vts]

The concerns above, as well as those mentioned in #914 are now being tracked in #1032.