Opened 12 years ago

Closed 12 years ago

#1113 closed defect (fixed)

changeset 10895 breaks compilation on mac

Reported by: Juicyfruit Owned by:
Priority: Should Have Milestone: Alpha 9
Component: Core engine Keywords:
Cc: Patch:

Description

Commit 10895 introduced the use of std::map in globals.h. With my setup the header for map does not seem to be included.

adding the one include did solve the issue

Attachments (1)

clean-build-mac-r10909.diff​ (15.3 KB ) - added by Echelon9 12 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by Echelon9, 12 years ago

Attaching a patchset, which I've been running with on Mac at all times, that addresses the include issues, the location of config files and an RGB issue.

See how that goes for you.

by Echelon9, 12 years ago

Attachment: clean-build-mac-r10909.diff​ added

comment:2 by Juicyfruit, 12 years ago

Hmmn the SDL revert is not needed. But it does contain some other good bits

comment:3 by Echelon9, 12 years ago

Yes, Philip` has since showed me how the "sdl-config --cflags" works -- so the SDL revert in my attached patch is not needed.

in reply to:  description comment:4 by historic_bruno, 12 years ago

Milestone: Backlog → Alpha 9

Replying to Juicyfruit:

Commit 10895 introduced the use of std::map in globals.h. With my setup the header for map does not seem to be included.

Hmm, is your setup not using precompiled headers (either using --without-pch or something else)? Anyway it will be fixed soon.

comment:5 by ben, 12 years ago

Resolution: → fixed
Status: new → closed

(In [10914]) Fixes no PCH build. Fixes #1113.

Note: See TracTickets for help on using tickets.