Ticket #1113 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

changeset 10895 breaks compilation on mac

Reported by: Juicyfruit Owned by:
Priority: Should Have Milestone: Alpha 9
Component: Core engine Keywords:
Cc:

Description

Commit 10895 introduced the use of std::map in globals.h. With my setup the header for map does not seem to be included.

adding the one include did solve the issue

Attachments

clean-build-mac-r10909.diff​ (15.3 KB) - added by Echelon9 4 months ago.

Change History

comment:1 Changed 4 months ago by Echelon9

Attaching a patchset, which I've been running with on Mac at all times, that addresses the include issues, the location of config files and an RGB issue.

See how that goes for you.

Changed 4 months ago by Echelon9

comment:2 Changed 4 months ago by Juicyfruit

Hmmn the SDL revert is not needed. But it does contain some other good bits

comment:3 Changed 4 months ago by Echelon9

Yes, Philip` has since showed me how the "sdl-config --cflags" works -- so the SDL revert in my attached patch is not needed.

comment:4 in reply to: ↑ description Changed 4 months ago by historic_bruno

  • Milestone changed from Backlog to Alpha 9

Replying to Juicyfruit:

Commit 10895 introduced the use of std::map in globals.h. With my setup the header for map does not seem to be included.

Hmm, is your setup not using precompiled headers (either using --without-pch or something else)? Anyway it will be fixed soon.

comment:5 Changed 4 months ago by ben

  • Status changed from new to closed
  • Resolution set to fixed

(In [10914]) Fixes no PCH build. Fixes #1113.

Note: See TracTickets for help on using tickets.