Opened 12 years ago

Closed 12 years ago

#1173 closed enhancement (fixed)

[PATCH] Make rally points work for trade

Reported by: Jonathan Waller Owned by: Deiz
Priority: Nice to Have Milestone: Alpha 11
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

When setting the rally point for a market on another market, any trained traders should automatically start a trade route between the two markets.

Attachments (1)

rallypoint-trade.patch​ (9.0 KB ) - added by Deiz 12 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by historic_bruno, 12 years ago

Assuming you mean after #30 is implemented :) (just so no one tries to start working on this before then)

comment:2 by Deiz, 12 years ago

Keywords: patch review added
Milestone: Backlog → Alpha 11
Owner: set to Deiz
Priority: Must Have → Nice to Have
Summary: Make rally points work for trade → [PATCH] Make rally points work for trade
Type: task → enhancement

Fairly simple patch. The tooltip's resource type is hard-coded to "metal" for now, as it can't be changed and is determined by cmpTrader rather than the market (I would like to change that, but that's for another patch).

It was necessary to load cmpTrader for SYSTEM_ENTITY. I'd prefer to not do that, but I don't think there's any way around it.

by Deiz, 12 years ago

Attachment: rallypoint-trade.patch​ added

comment:3 by Kieran P, 12 years ago

Keywords: trade rally point removed
Milestone: Alpha 11 → Alpha 12

comment:4 by Jonathan Waller, 12 years ago

Keywords: review removed
Milestone: Alpha 12 → Alpha 11

To avoid the nasty SYSTEM_ENTITY thing I moved the calculate gain function into helpers/TraderGain.js. Apart from that it looks like a nice patch and will be much appreciated by players.

comment:5 by Jonathan Waller, 12 years ago

Resolution: → fixed
Status: new → closed

In 12191:

Make rally points work for trade. Patch from Deiz/F00. Fixes #1173.

Note: See TracTickets for help on using tickets.